fix: remove QT logging rules check for UOS#152
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Jun 27, 2025
Merged
fix: remove QT logging rules check for UOS#15218202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's GuideThis PR removes the UOS-only export of QT_LOGGING_RULES from the Xsession environment script—preserving other Qt environment variables (e.g. QT_QPA_PLATFORM) and unifying debug-logging behavior across all editions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2a81f4b to
211a6d8
Compare
The change removes the conditional export of QT_LOGGING_RULES that was previously only set for UOS (UnionTech OS) but not Community edition. This environment variable controlled Qt program debug output. The removal suggests this logging control is no longer needed or should be handled differently, possibly because: 1. The logging behavior should be consistent across all editions 2. The logging control is being moved to a different configuration mechanism 3. The check was causing issues or wasn't providing value The change also maintains other important environment settings like QT_QPA_PLATFORM while removing this specific logging control. fix: 移除针对UOS的QT日志规则检查 此次变更移除了之前仅针对UOS(统信操作系统)非社区版设置的 QT_LOGGING_RULES条件导出。该环境变量原本用于控制Qt程序的调试输出。移除该 设置可能因为: 1. 日志行为应在所有版本中保持一致 2. 日志控制将被移至其他配置机制 3. 该检查存在问题或未提供实际价值 变更保留了其他重要的环境设置如QT_QPA_PLATFORM,同时移除了这个特定的日志 控制。
deepin pr auto review代码审查意见如下: debian/control 文件修改新增依赖项
代码质量
misc/Xsession.d/00deepin-dde-env 文件修改删除代码
代码质量
代码性能
代码安全
总结
|
mhduiy
approved these changes
Jun 26, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change removes the conditional export of QT_LOGGING_RULES that was
previously only set for UOS (UnionTech OS) but not Community edition.
This environment variable controlled Qt program debug output. The
removal suggests this logging control is no longer needed or should be
handled differently, possibly because:
mechanism
The change also maintains other important environment settings like
QT_QPA_PLATFORM while removing this specific logging control.
fix: 移除针对UOS的QT日志规则检查
此次变更移除了之前仅针对UOS(统信操作系统)非社区版设置的
QT_LOGGING_RULES条件导出。该环境变量原本用于控制Qt程序的调试输出。移除该
设置可能因为:
变更保留了其他重要的环境设置如QT_QPA_PLATFORM,同时移除了这个特定的日志
控制。
Summary by Sourcery
Remove the conditional QT_LOGGING_RULES export for UnionTech OS from the Xsession environment script to unify Qt logging behavior across all editions and rely on alternative configuration mechanisms.
Bug Fixes:
Enhancements: