Skip to content

fix: update systemd service configurations#153

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Jun 27, 2025
Merged

fix: update systemd service configurations#153
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Jun 27, 2025

  1. Changed restart policy from 'on-failure' to 'always' for dde-
    shell@DDE.service to ensure continuous operation
  2. These changes improve service reliability and simplify configuration
    by removing redundant limits

fix: 更新 systemd 服务配置

  1. dde-shell@DDE.service 的重启策略从 'on-failure' 改为 'always' 以确
    保持续运行
  2. 这些改动通过移除冗余限制提高了服务可靠性并简化了配置

pms:BUG-321773

Summary by Sourcery

Simplify and improve reliability of dde-shell systemd services by removing redundant restart limits and enabling continuous restarts for the main service

Enhancements:

  • Remove StartLimitBurst=3 from dde-shell and dde-shell-plugin services
  • Change Restart policy of dde-shell@DDE.service from 'on-failure' to 'always'

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 27, 2025

Reviewer's Guide

This PR simplifies and hardens dde-shell systemd unit configurations by removing unnecessary restart limits and enforcing a continuous restart policy for the main DDE service.

File-Level Changes

Change Details Files
Removed redundant StartLimitBurst setting from dde-shell services
  • Deleted StartLimitBurst=3 entry
  • Validated that service starts without burst limit
systemd/dde-session-initialized.target.wants/dde-shell-plugin@org.deepin.ds.desktop.service
systemd/dde-session-initialized.target.wants/dde-shell@DDE.service
Changed restart policy to always for the main dde-shell@DDE.service
  • Replaced Restart=on-failure with Restart=always
  • Reloaded systemd daemon and confirmed automatic restart behavior
systemd/dde-session-initialized.target.wants/dde-shell@DDE.service

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

yixinshark
yixinshark previously approved these changes Jun 27, 2025
1. Changed restart policy from 'on-failure' to 'always' for dde-
shell@DDE.service to ensure continuous operation
2. These changes improve service reliability and simplify configuration
by removing redundant limits

fix: 更新 systemd 服务配置

1. 将 dde-shell@DDE.service 的重启策略从 'on-failure' 改为 'always' 以确
保持续运行
2. 这些改动通过移除冗余限制提高了服务可靠性并简化了配置

pms:BUG-321773
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这个提交的改动主要是将 Restart=on-failure 改为 Restart=always,并且增加了 RestartSec=1s。以下是针对这个改动的审查意见:

代码质量

  • 可读性:改动后的配置文件仍然清晰易读,没有引入新的复杂度。

代码性能

  • 重启策略:将 Restart=on-failure 改为 Restart=always 可能会影响系统的稳定性,因为服务在失败时总是会被重启。建议在确认服务确实需要这种策略时再进行修改。
  • 延迟重启:增加了 RestartSec=1s,这有助于在服务失败后等待一段时间再重启,避免服务在短时间内频繁重启。这是一个合理的改动,有助于提高系统的稳定性。

代码安全

  • 无直接安全风险:这个改动本身不涉及安全性的问题。

语法逻辑

  • 语法正确:修改后的配置文件语法正确,没有引入语法错误。

其他建议

  • 文档更新:如果这个改动会影响服务的重启策略,建议更新相关的文档,说明为什么需要这样的改动,以及如何恢复到原来的策略。
  • 测试:在正式部署这个改动之前,建议在测试环境中进行充分的测试,确保服务的重启策略不会对用户体验或系统稳定性产生负面影响。

总的来说,这个改动是为了提高服务的稳定性,是一个合理的改动。但是,需要确保这个改动符合项目的需求,并且在实施之前进行充分的测试和评估。

@18202781743 18202781743 requested a review from yixinshark June 27, 2025 06:50
@18202781743
Copy link
Copy Markdown
Contributor Author

  1. Changed restart policy from 'on-failure' to 'always' for dde-
    shell@DDE.service to ensure continuous operation
  2. These changes improve service reliability and simplify configuration
    by removing redundant limits

fix: 更新 systemd 服务配置

  1. dde-shell@DDE.service 的重启策略从 'on-failure' 改为 'always' 以确
    保持续运行
  2. 这些改动通过移除冗余限制提高了服务可靠性并简化了配置

pms:BUG-321773

Summary by Sourcery

Simplify and improve reliability of dde-shell systemd services by removing redundant restart limits and enabling continuous restarts for the main service

Enhancements:

  • Remove StartLimitBurst=3 from dde-shell and dde-shell-plugin services
  • Change Restart policy of dde-shell@DDE.service from 'on-failure' to 'always'

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 2e7d48d into linuxdeepin:master Jun 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants