fix: update build hardening flags and cmake configuration#155
Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom Jul 3, 2025
Merged
fix: update build hardening flags and cmake configuration#155mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Removed redundant compiler flags from CMakeLists.txt that are now handled by debian/rules 2. Added security hardening build options in debian/rules including: - Enabling all hardening features - Adding -Wall warning flags for C/C++ - Setting secure linker flags (RELRO, NOW, noexecstack) 3. Cleaned up CMake configuration by removing duplicate flags that are now handled at Debian build level fix: 更新构建加固标志和cmake配置 1. 从CMakeLists.txt中移除了现在由debian/rules处理的冗余编译器标志 2. 在debian/rules中添加了安全加固构建选项包括: - 启用所有加固功能 - 为C/C++添加-Wall警告标志 - 设置安全链接器标志(RELRO, NOW, noexecstack) 3. 通过移除现在由Debian构建层处理的重复标志来清理CMake配置
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideThis PR consolidates security hardening and warning flags into the Debian build layer by removing redundant flags from CMakeLists.txt and introducing comprehensive build-hardening and warning options in debian/rules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
approved these changes
Jul 3, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 更新构建加固标志和cmake配置
Summary by Sourcery
Consolidate security and warning flags into debian/rules for build hardening and clean up redundant CMake settings
Enhancements:
Build: