fix: resolve audio service stop issue during logout#162
Merged
fly602 merged 1 commit intolinuxdeepin:masterfrom Sep 23, 2025
Merged
fix: resolve audio service stop issue during logout#162fly602 merged 1 commit intolinuxdeepin:masterfrom
fly602 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Previously, stopping audio service was handled asynchronously through direct service commands, which didn't guarantee immediate termination. This caused ALSA to remain occupied when playing logout sound effects, leading to playback failures. The fix replaces this with a synchronous call to the backend's StopAudioService method to ensure proper audio service termination before logout sound playback. Log: Fixed issue where logout sound effects failed to play due to audio service still running Influence: 1. Test logout sound effects playback during system logout 2. Verify audio service properly terminates before sound playback 3. Check system stability during logout sequence 4. Test with different audio backends (ALSA, PipeWire) fix: 解决注销时音频服务停止问题 之前通过直接服务命令异步停止音频服务,无法保证立即终止。这导致播 放注销音效时ALSA仍处于占用状态,造成播放失败。现改为同步调用后端的 StopAudioService方法,确保在播放注销音效前正确终止音频服务。 Log: 修复了由于音频服务仍在运行导致注销音效播放失败的问题 PMS: BUG-315787 Influence: 1. 测试系统注销时的注销音效播放 2. 验证音频服务在声音播放前正确终止 3. 检查注销序列中的系统稳定性 4. 使用不同音频后端(ALSA, PipeWire)进行测试
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the previous asynchronous STOP_SERVICE commands with a synchronous backend StopAudioService call to ensure the audio service is fully terminated before logout sound playback. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a timeout or watchdog around the synchronous StopAudioService call to prevent potential hangs during logout if the backend becomes unresponsive.
- Ensure StopAudioService properly handles both ALSA and PipeWire (including the PipeWire-Pulse socket) or add a fallback path for backends that don’t support it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a timeout or watchdog around the synchronous StopAudioService call to prevent potential hangs during logout if the backend becomes unresponsive.
- Ensure StopAudioService properly handles both ALSA and PipeWire (including the PipeWire-Pulse socket) or add a fallback path for backends that don’t support it.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Sep 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, stopping audio service was handled asynchronously through direct service commands, which didn't guarantee immediate termination. This caused ALSA to remain occupied when playing logout sound effects, leading to playback failures. The fix replaces this with a synchronous call to the backend's StopAudioService method to ensure proper audio service termination before logout sound playback.
Log: Fixed issue where logout sound effects failed to play due to audio service still running
Influence:
fix: 解决注销时音频服务停止问题
之前通过直接服务命令异步停止音频服务,无法保证立即终止。这导致播
放注销音效时ALSA仍处于占用状态,造成播放失败。现改为同步调用后端的
StopAudioService方法,确保在播放注销音效前正确终止音频服务。
Log: 修复了由于音频服务仍在运行导致注销音效播放失败的问题
PMS: BUG-315787
Influence:
Summary by Sourcery
Ensure the audio service is stopped synchronously before logout sound playback to prevent ALSA from remaining occupied and causing sound failures
Bug Fixes: