feat: exec auto start service after quick-login unlocked#170
Merged
yixinshark merged 1 commit intolinuxdeepin:masterfrom Nov 27, 2025
Merged
feat: exec auto start service after quick-login unlocked#170yixinshark merged 1 commit intolinuxdeepin:masterfrom
yixinshark merged 1 commit intolinuxdeepin:masterfrom
Conversation
quick-login was unlocked, then exec autostart service Log: as title Pms: BUG-321889
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the dde-quick-login X11 systemd unit so that an autostart service is executed after quick-login is unlocked, addressing BUG-321889. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review这是一个systemd服务配置文件的修改,我来分析一下这个变更:
b) 错误处理:
c) 安全性:
d) 性能考虑:
建议的改进版本: [Unit]
Description=Quick Login Service for X11
PartOf=dde-session-pre.target
Before=dde-session-pre.target
# SuccessExitStatus=0,launch dde-lock.service
OnSuccess=dde-lock.service dde-version-checker@quick-login.service dde-autostart@quick-login.service
OnFailure=dde-failure-handler@quick-login.service
[Service]
Slice=session.slice
# 添加以下配置以增强安全性
Type=oneshot
RemainAfterExit=yes这些修改建议:
建议在实际部署前进行充分测试,特别是:
|
BLumia
approved these changes
Nov 27, 2025
BLumia
approved these changes
Nov 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick-login was unlocked, then exec autostart service
Log: as title
Pms: BUG-321889
Summary by Sourcery
Enhancements: