feat: enhance login reminder with configurable settings#172
Merged
BLumia merged 1 commit intolinuxdeepin:masterfrom Dec 4, 2025
Merged
feat: enhance login reminder with configurable settings#172BLumia merged 1 commit intolinuxdeepin:masterfrom
BLumia merged 1 commit intolinuxdeepin:masterfrom
Conversation
BLumia
reviewed
Dec 3, 2025
1. Added DConfig support for LoginReminder configuration with default value false 2. Implemented password expiration check as fallback when LoginReminder is disabled 3. Replaced systemd service with desktop autostart file for better session integration 4. Added translation support with multiple language files (en_US, zh_CN, zh_HK, zh_TW) 5. Added D-Bus service watcher to wait for notification service availability 6. Improved notification content with detailed login information and password warnings 7. Added action button to directly open password change page in control center Log: Added configurable login reminder feature with password expiration warnings Influence: 1. Test login reminder functionality with DConfig enabled and disabled states 2. Verify password expiration notifications work independently 3. Check translation loading for different locales 4. Test notification action button opens control center password page 5. Verify autostart behavior after system login 6. Test D-Bus service dependency handling feat: 增强登录提醒功能并支持配置设置 1. 添加 DConfig 支持登录提醒配置,默认值为关闭 2. 实现密码过期检查作为登录提醒禁用时的备用功能 3. 将 systemd 服务替换为桌面自启动文件以实现更好的会话集成 4. 添加多语言翻译支持(英文、简体中文、繁体中文香港、繁体中文台湾) 5. 添加 D-Bus 服务监视器以等待通知服务可用 6. 改进通知内容,包含详细的登录信息和密码警告 7. 添加操作按钮可直接打开控制中心的密码修改页面 Log: 新增可配置的登录提醒功能,包含密码过期警告 Influence: 1. 测试 DConfig 启用和禁用状态下的登录提醒功能 2. 验证密码过期通知是否独立工作 3. 检查不同语言环境的翻译加载 4. 测试通知操作按钮是否打开控制中心密码页面 5. 验证系统登录后的自启动行为 6. 测试 D-Bus 服务依赖处理
BLumia
approved these changes
Dec 4, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Added configurable login reminder feature with password expiration warnings
Influence:
feat: 增强登录提醒功能并支持配置设置
Log: 新增可配置的登录提醒功能,包含密码过期警告
Influence: