Skip to content

chore: update REUSE license file patterns#175

Merged
fly602 merged 1 commit intolinuxdeepin:masterfrom
fly602:master
Dec 4, 2025
Merged

chore: update REUSE license file patterns#175
fly602 merged 1 commit intolinuxdeepin:masterfrom
fly602:master

Conversation

@fly602
Copy link
Copy Markdown
Contributor

@fly602 fly602 commented Dec 4, 2025

Updated the .reuse/dep5 file to include missing translation files and configuration files in the license declarations. Added tools/dde-login- reminder/translations/*.ts files to systemd config section and included *.sh files and additional configuration files to the xml/toml/json section. This ensures proper licensing coverage for recently added files and maintains compliance with REUSE specification requirements.

The changes ensure that new translation files and shell scripts are properly licensed under the appropriate categories. The systemd config section now includes translation files for the login reminder tool, while the configuration files section expands to cover shell scripts and additional desktop/configuration files.

chore: 更新 REUSE 许可证文件模式

更新 .reuse/dep5 文件以在许可证声明中包含缺失的翻译文件和配置文件。将
tools/dde-login-reminder/translations/*.ts 文件添加到 systemd 配置部分, 并将 *.sh 文件和其他配置文件添加到 xml/toml/json 部分。这确保新添加的文
件获得适当的许可证覆盖,并保持与 REUSE 规范要求的合规性。

这些更改确保新的翻译文件和 shell 脚本在适当的类别下获得正确的许可证授
权。systemd 配置部分现在包含了登录提醒工具的翻译文件,而配置文件部分扩展
以涵盖 shell 脚本和额外的桌面/配置文件。

Summary by Sourcery

Chores:

  • Expand .reuse/dep5 license patterns to include login reminder translation files, shell scripts, and additional configuration/desktop files for REUSE compliance.

Updated the .reuse/dep5 file to include missing translation files and
configuration files in the license declarations. Added tools/dde-login-
reminder/translations/*.ts files to systemd config section and included
*.sh files and additional configuration files to the xml/toml/json
section. This ensures proper licensing coverage for recently added files
and maintains compliance with REUSE specification requirements.

The changes ensure that new translation files and shell scripts are
properly licensed under the appropriate categories. The systemd config
section now includes translation files for the login reminder tool,
while the configuration files section expands to cover shell scripts and
additional desktop/configuration files.

chore: 更新 REUSE 许可证文件模式

更新 .reuse/dep5 文件以在许可证声明中包含缺失的翻译文件和配置文件。将
tools/dde-login-reminder/translations/*.ts 文件添加到 systemd 配置部分,
并将 *.sh 文件和其他配置文件添加到 xml/toml/json 部分。这确保新添加的文
件获得适当的许可证覆盖,并保持与 REUSE 规范要求的合规性。

这些更改确保新的翻译文件和 shell 脚本在适当的类别下获得正确的许可证授
权。systemd 配置部分现在包含了登录提醒工具的翻译文件,而配置文件部分扩展
以涵盖 shell 脚本和额外的桌面/配置文件。
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the REUSE dep5 configuration to add missing translation, shell script, and configuration file patterns so they are covered by the appropriate license declarations.

File-Level Changes

Change Details Files
Extend REUSE dep5 file patterns to cover new translation files, shell scripts, and additional configuration/desktop files under existing license sections.
  • Add tools/dde-login-reminder/translations/*.ts pattern to the systemd configuration license section so translation files inherit the same licensing as the login reminder tool configs.
  • Broaden the xml/toml/json configuration section to also match *.sh scripts, ensuring shell utilities are explicitly covered by the configuration/licenses block.
  • Include additional desktop/configuration file patterns in the xml/toml/json section to keep REUSE coverage aligned with newly introduced config assets.
.reuse/dep5

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

我来对这个diff进行审查:

  1. 语法逻辑分析:
  • 这个diff修改的是.reuse/dep5文件,这是一个用于软件许可证合规性管理的文件
  • 修改主要是在Files字段中添加了新的文件路径
  • 语法格式符合dep5规范,使用通配符和具体路径相结合的方式
  1. 代码质量分析:
  • 文件路径的添加是合理的,遵循了项目的目录结构
  • 新增的文件类型(.ts, .sh, .desktop)与原有配置保持一致
  • 路径格式统一,使用斜杠(/)作为分隔符
  1. 改进建议:

a) 路径组织优化:
建议将相同类型的文件归类在一起,例如:

Files: dbus/*.service tools/*.service systemd/*

而不是:

Files: dbus/*.service systemd/* tools/*.service

b) 通配符使用:
对于src/*.yaml这样的模式,建议检查是否所有yaml文件都确实应该使用CC0-1.0许可证

c) 文件路径完整性:
新增的路径中,tools/dde-login-reminder/translations/*.ts和tools/dde-login-reminder/dde-login-reminder.desktop属于同一功能模块,建议将它们放在同一个Files条目中

d) 许可证一致性:
建议确认所有新增文件确实符合指定的许可证要求,特别是:

  • .ts文件(翻译文件)
  • .sh文件(shell脚本)
  • .desktop文件(桌面配置文件)
  1. 安全性考虑:
  • 确保所有新增文件都包含适当的安全头信息
  • 对于.sh文件,建议添加适当的权限控制说明
  1. 建议的改进版本:
# systemd config file
Files: dbus/*.service tools/*.service systemd/*
Copyright: UnionTech Software Technology Co., Ltd.
License: LGPL-3.0-or-later

# xml toml json conf yaml
Files: src/*.xml .clog.toml configs/*.json src/*conf src/*.yaml
Copyright: None
License: CC0-1.0

# shell scripts and desktop files
Files: *.sh tools/dde-login-reminder/dde-login-reminder.desktop
Copyright: None
License: CC0-1.0

# translation files
Files: tools/dde-login-reminder/translations/*.ts .tx/config .tx/transifex.yaml
Copyright: None
License: CC0-1.0

这样的组织更加清晰,便于维护和管理。同时建议在添加新文件时,确保它们确实符合指定的许可证要求。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 merged commit 62c89ea into linuxdeepin:master Dec 4, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants