Skip to content

Commit 86d82f8

Browse files
committed
refactor: move dockiteminfo to shared frame library
1. Moved dockiteminfo.h and dockiteminfo.cpp from panels/dock to frame directory 2. Updated CMakeLists.txt in frame to include dockiteminfo as a public header and source file 3. Removed dockiteminfo files from panels/dock CMakeLists.txt and its subdirectories (appruntimeitem, multitaskview, tray) 4. Updated include statements in multiple dock components to use <dockiteminfo.h> instead of "dockiteminfo.h" 5. This refactoring centralizes dockiteminfo as a shared component accessible across different modules Log: Refactored dockiteminfo to be part of shared frame library Influence: 1. Verify dock functionality still works correctly after the move 2. Test application runtime items display properly in dock 3. Check multitask view functionality 4. Verify system tray items work as expected 5. Ensure all dock components can access dockiteminfo without compilation errors 6. Test build process to confirm no missing dependencies refactor: 将 dockiteminfo 移动到共享框架库 1. 将 dockiteminfo.h 和 dockiteminfo.cpp 从 panels/dock 移动到 frame 目录 2. 更新 frame 中的 CMakeLists.txt,将 dockiteminfo 添加为公共头文件和源 文件 3. 从 panels/dock 及其子目录(appruntimeitem、multitaskview、tray)的 CMakeLists.txt 中移除 dockiteminfo 文件 4. 更新多个 dock 组件中的包含语句,使用 <dockiteminfo.h> 替代 "dockiteminfo.h" 5. 此次重构将 dockiteminfo 集中为可在不同模块间访问的共享组件 Log: 重构 dockiteminfo 使其成为共享框架库的一部分 Influence: 1. 验证移动后 dock 功能是否正常工作 2. 测试应用程序运行时项目在 dock 中正确显示 3. 检查多任务视图功能 4. 验证系统托盘项目按预期工作 5. 确保所有 dock 组件都能访问 dockiteminfo 而无编译错误 6. 测试构建过程以确认没有缺失的依赖项
1 parent ee4443f commit 86d82f8

9 files changed

Lines changed: 11 additions & 17 deletions

File tree

frame/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ set(PUBLIC_HEADERS
1717
layershell/dlayershellwindow.h
1818
models/listtotableproxymodel.h
1919
dsutility.h
20+
dockiteminfo.h
2021
)
2122

2223
set(PRIVATE_HEADERS
@@ -63,6 +64,7 @@ add_library(dde-shell-frame SHARED
6364
qmlengine.cpp
6465
appletitemmodel.h
6566
appletitemmodel.cpp
67+
dockiteminfo.cpp
6668
dsqmlglobal.cpp
6769
layershell/dlayershellwindow.cpp
6870
layershell/qwaylandlayershellsurface.cpp
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
1+
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
22
//
33
// SPDX-License-Identifier: GPL-3.0-or-later
44

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
1+
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
22
//
33
// SPDX-License-Identifier: GPL-3.0-or-later
44
#pragma once

panels/dock/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
1+
# SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
22
#
33
# SPDX-License-Identifier: GPL-3.0-or-later
44

@@ -18,8 +18,6 @@ file(
1818
dockabstractsettingsconfig.h
1919
dockdbusproxy.cpp
2020
dockdbusproxy.h
21-
dockiteminfo.cpp
22-
dockiteminfo.h
2321
dockpanel.cpp
2422
dockpanel.h
2523
docksettings.cpp

panels/dock/appruntimeitem/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
1+
# SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
22
#
33
# SPDX-License-Identifier: GPL-3.0-or-later
44

@@ -13,8 +13,6 @@ add_library(dock-appruntimeitem SHARED
1313
xcbgetinfo.h
1414
xcbgetinfo.cpp
1515
qmlappruntime.qrc
16-
${CMAKE_SOURCE_DIR}/panels/dock/dockiteminfo.cpp
17-
${CMAKE_SOURCE_DIR}/panels/dock/dockiteminfo.h
1816
${CMAKE_SOURCE_DIR}/panels/dock/constants.h
1917
${CMAKE_SOURCE_DIR}/panels/dock/taskmanager/x11utils.h
2018
${CMAKE_SOURCE_DIR}/panels/dock/taskmanager/x11utils.cpp

panels/dock/multitaskview/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
1+
# SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
22
#
33
# SPDX-License-Identifier: GPL-3.0-or-later
44

@@ -12,8 +12,6 @@ add_library(dock-multitaskview SHARED
1212
multitaskview.h
1313
treelandmultitaskview.cpp
1414
treelandmultitaskview.h
15-
../dockiteminfo.cpp
16-
../dockiteminfo.h
1715
)
1816

1917
target_include_directories(dock-multitaskview PRIVATE

panels/dock/multitaskview/multitaskview.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
1+
// SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
22
//
33
// SPDX-License-Identifier: GPL-3.0-or-later
44

55
#pragma once
66

7-
#include "../dockiteminfo.h"
7+
#include "dockiteminfo.h"
88
#include "applet.h"
99
#include "dsglobal.h"
1010
#include "treelandmultitaskview.h"

panels/dock/tray/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
1+
# SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
22
#
33
# SPDX-License-Identifier: CC0-1.0
44

@@ -42,8 +42,6 @@ add_library(trayitem SHARED
4242
trayitem.h
4343
traysettings.cpp
4444
traysettings.h
45-
../dockiteminfo.cpp
46-
../dockiteminfo.h
4745
../constants.h
4846
)
4947

panels/dock/tray/trayitem.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
1+
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
22
//
33
// SPDX-License-Identifier: GPL-3.0-or-later
44

0 commit comments

Comments
 (0)