chore: implement dock item menus for DockGlobalElementModel

This patch is to continue prepare for #1201,
by add previously missing changed signal for Docked and Menu role
when docked state is changed, and implementing actions for menu
entries.

This patch also make DnD on dock item works without using the
legacy ItemModel class by implementing requestOpenUrls().

Log:

Author: BLumia

panels/dock/taskmanager/desktopfileabstractparser.cpp

@@ -148,9 +148,9 @@ void DesktopfileAbstractParser::setDocked(bool docked)
     auto desktopElement = QStringLiteral("desktop/%1").arg(id());
 
     if (docked) {
-        TaskManagerSettings::instance()->appendDockedElements(desktopElement);
+        TaskManagerSettings::instance()->appendDockedElement(desktopElement);
     } else {
-        TaskManagerSettings::instance()->removeDockedElements(desktopElement);
+        TaskManagerSettings::instance()->removeDockedElement(desktopElement);
     }
 
     Q_EMIT dockedChanged();

panels/dock/taskmanager/dockglobalelementmodel.cpp

@@ -3,11 +3,13 @@
 // SPDX-License-Identifier: GPL-3.0-or-later
 
 #include "dockglobalelementmodel.h"
+#include "applicationinterface.h"
 #include "globals.h"
 #include "taskmanager.h"
 #include "taskmanagersettings.h"
 
 #include <QAbstractListModel>
+#include <QDBusConnection>
 #include <QJsonDocument>
 #include <QJsonObject>
 #include <QProcess>
@@ -234,6 +236,11 @@ void DockGlobalElementModel::loadDockedElements()
     }
 
     m_dockedElements = newDocked;
+
+    if (!m_data.isEmpty()) {
+        // MenusRole should also be handled here due to it contains the copywriting of docked or undocked
+        Q_EMIT dataChanged(index(0, 0), index(m_data.size() - 1, 0), {TaskManager::DockedRole, TaskManager::MenusRole});
+    }
 }
 
 QString DockGlobalElementModel::getMenus(const QModelIndex &index) const
@@ -318,15 +325,33 @@ void DockGlobalElementModel::requestActivate(const QModelIndex &index) const
 
 void DockGlobalElementModel::requestOpenUrls(const QModelIndex &index, const QList<QUrl> &urls) const
 {
-    Q_UNUSED(index)
-    Q_UNUSED(urls)
+    auto data = m_data.value(index.row());
+    auto id = std::get<0>(data);
+
+    QStringList urlStrings;
+    for (const QUrl &url : urls) {
+        urlStrings.append(url.toLocalFile());
+    }
+
+    QString dbusPath = QStringLiteral("/org/desktopspec/ApplicationManager1/") + escapeToObjectPath(id);
+    using Application = org::desktopspec::ApplicationManager1::Application;
+    Application appInterface(QStringLiteral("org.desktopspec.ApplicationManager1"), dbusPath, QDBusConnection::sessionBus());
+
+    if (appInterface.isValid()) {
+        appInterface.Launch(QString(), urlStrings, QVariantMap());
+    }
 }
 
 void DockGlobalElementModel::requestNewInstance(const QModelIndex &index, const QString &action) const
 {
     if (action == DOCK_ACTION_DOCK) {
+        auto data = m_data.value(index.row());
+        auto id = std::get<0>(data);
+        TaskManagerSettings::instance()->toggleDockedElement(QStringLiteral("desktop/%1").arg(id));
     } else if (action == DOCK_ACTION_FORCEQUIT) {
+        requestClose(index, true);
     } else if (action == DOCK_ACTION_CLOSEALL) {
+        requestClose(index);
     } else {
         auto data = m_data.value(index.row());
         auto id = std::get<0>(data);

panels/dock/taskmanager/dockgroupmodel.cpp

@@ -117,12 +117,6 @@ void DockGroupModel::requestActivate(const QModelIndex &index) const
     interface->requestActivate(sourceIndex);
 }
 
-void DockGroupModel::requestOpenUrls(const QModelIndex &index, const QList<QUrl> &urls) const
-{
-    Q_UNUSED(index)
-    Q_UNUSED(urls)
-}
-
 void DockGroupModel::requestClose(const QModelIndex &index, bool force) const
 {
     auto interface = dynamic_cast<AbstractTaskManagerInterface *>(sourceModel());

panels/dock/taskmanager/dockgroupmodel.h

@@ -20,7 +20,6 @@ class DockGroupModel : public RoleGroupModel, public AbstractTaskManagerInterfac
     Q_INVOKABLE virtual QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
 
     void requestActivate(const QModelIndex &index) const override;
-    void requestOpenUrls(const QModelIndex &index, const QList<QUrl> &urls) const override;
     void requestClose(const QModelIndex &index, bool force = false) const override;
     void requestUpdateWindowGeometry(const QModelIndex &index, const QRect &geometry, QObject *delegate = nullptr) const override;
     void requestPreview(const QModelIndexList &indexes,

panels/dock/taskmanager/taskmanager.cpp

@@ -271,10 +271,17 @@ void TaskManager::clickItem(const QString& itemId, const QString& menuId)
 
 void TaskManager::dropFilesOnItem(const QString& itemId, const QStringList& urls)
 {
-    auto item = ItemModel::instance()->getItemById(itemId);
-    if(!item) return;
+    auto indexes = m_itemModel->match(m_itemModel->index(0, 0), TaskManager::ItemIdRole, itemId, 1, Qt::MatchExactly);
+    if (indexes.isEmpty()) {
+        return;
+    }
+
+    QList<QUrl> urlList;
+    for (const QString &url : urls) {
+        urlList.append(QUrl::fromLocalFile(url));
+    }
 
-    item->handleFileDrop(urls);
+    m_itemModel->requestOpenUrls(indexes.first(), urlList);
 }
 
 void TaskManager::showItemPreview(const QString &itemId, QObject *relativePositionItem, int32_t previewXoffset, int32_t previewYoffset, uint32_t direction)

panels/dock/taskmanager/taskmanagersettings.cpp

@@ -148,14 +148,23 @@ void TaskManagerSettings::setDockedElements(const QStringList &elements)
     saveDockedElements();
 }
 
-void TaskManagerSettings::appendDockedElements(const QString &element)
+void TaskManagerSettings::toggleDockedElement(const QString &element)
+{
+    if (isDocked(element)) {
+        removeDockedElement(element);
+    } else {
+        appendDockedElement(element);
+    }
+}
+
+void TaskManagerSettings::appendDockedElement(const QString &element)
 {
     m_dockedElements.append(element);
     Q_EMIT dockedElementsChanged();
     saveDockedElements();
 }
 
-void TaskManagerSettings::removeDockedElements(const QString &element)
+void TaskManagerSettings::removeDockedElement(const QString &element)
 {
     m_dockedElements.removeAll(element);
     Q_EMIT dockedElementsChanged();

panels/dock/taskmanager/taskmanagersettings.h

@@ -32,8 +32,9 @@ class TaskManagerSettings : public QObject
     bool cgroupsBasedGrouping() const;
 
     void setDockedElements(const QStringList &elements);
-    void appendDockedElements(const QString &element);
-    void removeDockedElements(const QString &element);
+    void toggleDockedElement(const QString &element);
+    void appendDockedElement(const QString &element);
+    void removeDockedElement(const QString &element);
     QStringList dockedElements() const;
     bool isDocked(const QString &elementId) const;