Skip to content

chore: drop no longer existed translation resource#1120

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:remove-404-res
May 8, 2025
Merged

chore: drop no longer existed translation resource#1120
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:remove-404-res

Conversation

@BLumia

@BLumia BLumia commented May 8, 2025 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Member

删除不再存在的翻译资源

Summary by Sourcery

Remove outdated translation resource for dock plugin

Chores:

  • Remove translation configuration for dock plugin from Transifex configuration
  • Delete Turkish translation file for dock plugin

@BLumia
chore: drop no longer existed translation resource
fd88b1d 
删除不再存在的翻译资源

Log:
@BLumia BLumia requested a review from mhduiy May 8, 2025 12:57
@deepin-ci-robot

deepin-ci-robot commented May 8, 2025

Copy link
Copy Markdown

deepin pr auto review

代码审查意见：

  1. 代码删除：

    • 删除了dock_tr.ts文件，这可能会影响翻译的完整性。如果这个文件不再需要，应该在提交信息中说明删除的原因，并确保所有相关的翻译文件都已更新或确认不再需要。

  2. 配置文件更新：

    • .tx/transifex.yaml文件中的filters部分删除了与dock.ts相关的配置。如果这个删除是故意的，应该确保所有相关的翻译工作都已经完成，并且没有遗漏任何需要翻译的内容。

  3. 文件格式和语言：

    • 确保所有删除的翻译文件都符合项目的文件格式和语言标准。如果有任何格式或语言上的不一致，应该进行相应的调整。

  4. 代码注释：

    • 在删除代码时，应该添加注释说明为什么删除这些文件，以及这些删除是否会影响其他部分的代码。这有助于其他开发者理解代码的变更历史。

  5. 版本控制：

    • 确保在删除文件后，版本控制系统中的其他文件（如.tx/transifex.yaml）也进行了相应的更新，并且这些更新都已经提交。

  6. 翻译文件管理：

    • 如果项目中有多个翻译文件，应该确保所有相关的翻译文件都已经更新，并且没有遗漏任何需要翻译的内容。

  7. 测试：

    • 在删除翻译文件后，应该进行全面的测试，确保删除操作没有引入任何新的错误或问题。

总结：删除翻译文件和配置需要谨慎处理，确保不会影响项目的翻译工作。在删除之前，应该进行充分的测试和确认，并且添加必要的注释说明。

@sourcery-ai

sourcery-ai Bot commented May 8, 2025

Copy link
Copy Markdown

Reviewer's Guide

This pull request removes an obsolete translation resource by deleting its configuration entry from the .tx/transifex.yaml file and removing the corresponding Turkish translation file.

File-Level Changes

Change Details Files
Removed Transifex configuration for a dock plugin translation.
  • Deleted the filter entry for panels/dock/dcc-dock-plugin/translations/dock.ts which specified the source file and translation expression for the dock plugin translations. This change effectively disconnects this translation resource from the Transifex localization workflow.
 .tx/transifex.yaml
Deleted an unused translation file.
  • Removed the dock_tr.ts file, which contained Turkish translations for the dock plugin. This file is no longer needed as the corresponding source has been removed from the Transifex configuration.
 panels/dock/dcc-dock-plugin/translations/dock_tr.ts
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed May 8, 2025
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes - here's some feedback:

  • Since the Transifex configuration for panels/dock/dcc-dock-plugin/translations/dock.ts has been removed, ensure all associated dock_<lang>.ts translation files are also deleted from panels/dock/dcc-dock-plugin/translations/.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

deepin-ci-robot commented May 8, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit af7d445 into linuxdeepin:master May 8, 2025
7 of 10 checks passed
@BLumia BLumia deleted the remove-404-res branch May 8, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@mhduiy mhduiy mhduiy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BLumia @deepin-ci-robot @mhduiy