refactor: prepare for combined model for taskmanager#1126
Merged
Conversation
Reviewer's GuideRefactor introduces a unified proxy‐model pipeline and an abstract interface to prepare for a combined model in TaskManager, without altering existing behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @BLumia - I've reviewed your changes - here's some feedback:
- The stubbed-out AbstractTaskManagerInterface methods in DockGlobalElementModel (e.g. requestOpenUrls, requestUpdateWindowGeometry, requestWindowsView) are currently no-ops—either implement them or remove them to avoid silent failures.
- Avoid using synchronous QProcess::waitForFinished in DockGlobalElementModel::requestNewInstance since it blocks the UI thread; consider launching the process asynchronously or using a job API instead.
- In BoolFilterModel::filterAcceptsRow, the check
if (sourceRow > sourceModel()->rowCount())should use>=to correctly guard against out-of-range row indices.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0adae88 to
145b6a0
Compare
18202781743
reviewed
May 16, 2025
de92edc to
100ddf3
Compare
18202781743
reviewed
May 16, 2025
18202781743
reviewed
May 16, 2025
100ddf3 to
dd30123
Compare
18202781743
reviewed
May 16, 2025
为后续多任务区域切换到新的合并模型做出准备. 目前的表现行为仍然和之前一致,无行为变化(taskmanager实际使用的仍然是原模型). Log:
dd30123 to
165193f
Compare
18202781743
approved these changes
May 19, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为后续多任务区域切换到新的合并模型做出准备。
目前的表现行为仍然和之前一致,无行为变化(taskmanager实际使用的仍然是原模型)。
Summary by Sourcery
Refactor TaskManager to build a new combined data-model pipeline through proxy models and an abstract interface, enabling future multi-task area support without altering current behavior.
Enhancements:
Build: