chore: simplify window effect descriptions#1132
Merged
Merged
Conversation
1. Removed redundant prefixes ("Optimal performance:", "Balance:", "Best
visuals:") from descriptions in main.qml
2. Updated translation files to match the simplified descriptions
3. This change makes the UI text more concise while maintaining clarity
4. The modification affects all language translations to ensure
consistency
chore: 简化窗口特效描述文本
1. 移除了 main.qml 中描述文本的多余前缀("最佳性能:"、"均衡:"、"最佳
视觉:")
2. 更新翻译文件以匹配简化后的描述文本
3. 这一改动使界面文本更加简洁同时保持清晰
4. 修改影响了所有语言翻译以确保一致性
pms: BUG-313277
Reviewer's GuideThis PR streamlines window effect descriptions by removing mode-prefixes from the UI text in main.qml and synchronously updating all translation source files to match the new concise sentences. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @mhduiy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
May 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: 简化窗口特效描述文本
pms: BUG-313277
Summary by Sourcery
Simplify the window effect mode descriptions by removing redundant prefixes and update all translation files to reflect the new, concise text
Enhancements: