fix: The tray window panel automatically opens#1143
Merged
Conversation
Add popup visibility handler to ActionShowStashDelegate Introduce a Connections block to handle `stashedPopup.popupVisibleChanged` signal. When the popup is hidden and no item is being dragged, reset `dropHoverIndex` to -1. This ensures proper state management when the popup visibility changes. pms: BUG-317959
Reviewer's GuideImplements a Connections block to listen for stashedPopup.popupVisibleChanged, resetting dropHoverIndex to -1 when the popup closes without an active drag to maintain correct state management. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Hey @robertkill - I've reviewed your changes - here's some feedback:
- The description mentions logging the popup visibility change, but the handler only resets dropHoverIndex—consider adding a console.log call (or equivalent) inside onPopupVisibleChanged to record the event.
- Instead of a separate Connections block, you could define onPopupVisibleChanged directly on the stashedPopup element to keep the handler co-located and avoid null-target issues.
- Consider placing the visibility-changed handler adjacent to the stashedPopup declaration for better readability and context.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BLumia
approved these changes
Jun 5, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a Connections block to handle
stashedPopup.popupVisibleChangedsignal. When the popup is hidden and no item is being dragged, resetdropHoverIndexto -1. This ensures proper state management when the popup visibility changes.pms: BUG-317959
Summary by Sourcery
Bug Fixes: