fix: cannot build on Archlinux#1176
Conversation
Reviewer's GuideThis PR implements build-time detection of Deepin Qt’s Wayland API on Archlinux by integrating a try_compile check, adds required Qt Wayland components, and wraps Deepin-specific QtWayland extensions in conditional compilation. Entity relationship diagram for added Qt Wayland componentserDiagram
QT_CORE ||--o{ QT_GUI : uses
QT_GUI ||--o{ QT_CONCURRENT : uses
QT_GUI ||--o{ QT_QUICK : uses
QT_GUI ||--o{ QT_WAYLANDCLIENT : uses
QT_GUI ||--o{ QT_WAYLANDCOMPOSITOR : uses
QT_WAYLANDCOMPOSITOR ||--o{ QT_WAYLANDCOMPOSITORPRIVATE : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @justforlxz - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justforlxz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justforlxz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dock use some only deepin of qt api. Log:
deepin pr auto review代码审查意见: CMakeLists.txt 文件修改:
pluginmanagerextension.cpp 文件修改:
qt_wayland_keyextension.cpp 文件修改:
总体来说,代码修改是合理的,但需要注意以下几点:
|
dock use some only deepin of qt api.
Log:
Summary by Sourcery
Detect and conditionally enable Deepin Qt WaylandCompositor extensions at build time to restore compatibility on Arch Linux distributions without Deepin Qt.
Bug Fixes:
Enhancements:
Build:
Tests: