Skip to content

fix: fix safe build.#1177

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-safeBuild
Jul 3, 2025
Merged

fix: fix safe build.#1177
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-safeBuild

Conversation

@wjyrich

@wjyrich wjyrich commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

as title.

Logs:

Summary by Sourcery

Bug Fixes:

  • Update debian/rules to correct safe build errors

as title.

Logs:
@sourcery-ai

sourcery-ai Bot commented Jul 3, 2025

Copy link
Copy Markdown

Reviewer's Guide

Modifies debian/rules to enforce safe-build constraints by updating debhelper compatibility and refining build overrides.

File-Level Changes

Change Details Files
Configure safe build options in debian/rules
  • Bumped debhelper compatibility level
  • Added override_dh_auto_configure to inject safe-build variables
  • Removed deprecated arguments from dh commands
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • debian/rules文件中添加了编译选项以提高代码质量和安全性。

是否建议立即修改:

  • 否,这些修改看起来是合理的,旨在提高软件的编译质量、安全性和性能。但是,需要确保这些编译选项不会与现有的构建系统或依赖项产生冲突。如果这些选项已经过测试并且与项目的其他部分兼容,那么可以接受这些更改。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich

wjyrich commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Jul 3, 2025

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot deepin-bot Bot merged commit 8498f5c into linuxdeepin:master Jul 3, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants