Skip to content

chore: reduce layershell emulate log message's log level#1179

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:log-level
Jul 7, 2025
Merged

chore: reduce layershell emulate log message's log level#1179
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:log-level

Conversation

@BLumia

@BLumia BLumia commented Jul 4, 2025

Copy link
Copy Markdown
Member

降低 layershell 协议模拟行为对应的日志等级

Summary by Sourcery

Reduce the log severity of the layershell X11 emulation warning and apply minor formatting cleanups

Chores:

  • Change layershell fallback log from warning to info
  • Remove extraneous trailing whitespace in setter methods

降低 layershell 协议模拟行为对应的日志等级

Log:
@BLumia BLumia requested review from 18202781743 and robertkill July 4, 2025 02:37
@sourcery-ai

sourcery-ai Bot commented Jul 4, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR lowers the log level for layershell’s X11 emulation message from warning to info and removes unnecessary trailing whitespace in several method definitions.

Class diagram for DLayerShellWindow logging change

classDiagram
    class DLayerShellWindow {
        +DLayerShellWindow(QWindow* window)
        +setKeyboardInteractivity(KeyboardInteractivity interactivity)
        +setCloseOnDismissed(bool close)
        +setScope(const QString& scope)
        +keyboardInteractivity() const
        +scope() const
    }
    class LayerShellEmulation {
        +LayerShellEmulation(QWindow* window, DLayerShellWindow* parent)
    }
    DLayerShellWindow --> LayerShellEmulation : creates
Loading

File-Level Changes

Change Details Files
Lowered emulation log level
  • Replaced qCWarning with qCInfo for non-Wayland X11 emulation
frame/layershell/dlayershellwindow.cpp
Cleaned up trailing whitespace
  • Removed extra spaces after closing braces in multiple setters
frame/layershell/dlayershellwindow.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 代码中的注释被删除,可能会影响代码的可读性和维护性。
  • 日志级别从警告(qCWarning)更改为信息(qCInfo),这可能是为了减少日志噪音,但需要确认这是否符合项目的日志策略。

是否建议立即修改:

  • 是,建议恢复注释以保持代码的清晰度。
  • 是,需要确认日志级别的更改是否符合项目的日志策略,并确保这一更改不会掩盖潜在的问题。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 8d366ef into linuxdeepin:master Jul 7, 2025
7 of 10 checks passed
@BLumia BLumia deleted the log-level branch July 7, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants