Skip to content

chore: bump CMake minimum required version to 3.16#1246

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:cmake-minimum-version
Sep 17, 2025
Merged

chore: bump CMake minimum required version to 3.16#1246
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:cmake-minimum-version

Conversation

@BLumia

@BLumia BLumia commented Sep 15, 2025

Copy link
Copy Markdown
Member

这是 Qt 6 所要求的最低 CMake 版本(尽管低于此版本不会导致无法构建).

Summary by Sourcery

Chores:

  • Increase CMake minimum required version from 3.10 to 3.16

这是 Qt 6 所要求的最低 CMake 版本(尽管低于此版本不会导致无法构建).

Log:
@BLumia BLumia requested a review from 18202781743 September 15, 2025 10:09
@sourcery-ai

sourcery-ai Bot commented Sep 15, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bump the project’s minimum CMake version from 3.10 to 3.16 to satisfy Qt 6 requirements.

File-Level Changes

Change Details Files
Update CMake minimum required version
  • Increased version check from 3.10 to 3.16
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

根据提供的git diff,我看到对CMakeLists.txt文件进行了修改,主要是提高了CMake的最低版本要求。以下是我的审查意见:

语法逻辑

  • 语法正确,CMAKE_MINIMUM_REQUIRED的写法符合CMake规范
  • 版本号从3.10提升到3.16,这是一个合理的升级

代码质量

  • 提高最低CMake版本要求可以确保使用更新的CMake特性和更好的错误检查
  • CMake 3.16相比3.10提供了更多现代化功能和改进的错误提示
  • 这种修改有助于项目维护,确保构建环境的一致性

代码性能

  • 性能影响微乎其微,CMake版本提升主要是为了利用新特性和改进的错误处理
  • 新版本CMake可能在某些操作上有轻微的性能优化

代码安全

  • 提高CMake版本要求有助于避免使用可能存在已知旧版本中的安全问题
  • 新版本CMake通常有更好的错误处理和安全检查

改进建议

  1. 考虑在项目文档中明确说明所需的CMake最低版本要求,以便开发者了解
  2. 可以考虑添加对CMake版本的检查,如果使用低于要求的版本给出明确错误信息:
if(CMAKE_VERSION VERSION_LESS 3.16)
    message(FATAL_ERROR "CMake version 3.16 or higher is required")
endif()
  1. 如果项目中有特定的CMake功能依赖3.16版本,建议添加注释说明原因,例如:
# Require CMake 3.16+ for CMP0067 policy (support for IN_LIST operator)

总体来说,这是一个合理的改进,有助于项目维护和构建环境的现代化。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit c951eb6 into linuxdeepin:master Sep 17, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants