chore: bump CMake minimum required version to 3.16#1246
Merged
Conversation
这是 Qt 6 所要求的最低 CMake 版本(尽管低于此版本不会导致无法构建). Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBump the project’s minimum CMake version from 3.10 to 3.16 to satisfy Qt 6 requirements. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review根据提供的git diff,我看到对CMakeLists.txt文件进行了修改,主要是提高了CMake的最低版本要求。以下是我的审查意见: 语法逻辑
代码质量
代码性能
代码安全
改进建议
if(CMAKE_VERSION VERSION_LESS 3.16)
message(FATAL_ERROR "CMake version 3.16 or higher is required")
endif()
# Require CMake 3.16+ for CMP0067 policy (support for IN_LIST operator)总体来说,这是一个合理的改进,有助于项目维护和构建环境的现代化。 |
18202781743
approved these changes
Sep 16, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这是 Qt 6 所要求的最低 CMake 版本(尽管低于此版本不会导致无法构建).
Summary by Sourcery
Chores: