fix: ensure panel tooltips are capitalized#1249
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestructures the font declaration in PanelToolTip.qml to apply per-word capitalization by converting the font property to an object and specifying the family, pointSize, and capitalization settings. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
reviewed
Sep 18, 2025
确保面板的 tooltip 提示逐词首字母大写. PMS: BUG-334469 Log:
deepin pr auto review这段代码是关于PanelToolTip.qml中字体设置的修改,我来分析一下这个改动:
改进建议:
修改建议如下: font {
family: DTK.fontManager.t6.family
pixelSize: DTK.fontManager.t6.pixelSize
// 如果确实需要文本大写,请取消下面的注释
// capitalization: Font.Capitalize
}或者更好的方式是: // 如果不需要文本大写转换
font: DTK.fontManager.t6
// 如果需要文本大写转换,建议添加注释说明原因
font {
family: DTK.fontManager.t6.family
pixelSize: DTK.fontManager.t6.pixelSize
// 将所有文本转换为大写显示
capitalization: Font.Capitalize
} |
18202781743
approved these changes
Sep 18, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
确保面板的 tooltip 提示逐词首字母大写.
潜在影响:所有 panel tooltip 的文本都会遵循首字母大写的显示方式。目前检查没发现例外,如果有的话就得把这个选项导出成属性,允许各个组件主动设置了。
Summary by Sourcery
Bug Fixes: