refactor: move dockiteminfo to shared frame library#1551
Merged
Conversation
BLumia
previously approved these changes
Apr 13, 2026
1. Moved dockiteminfo.h and dockiteminfo.cpp from panels/dock to frame directory 2. Updated CMakeLists.txt in frame to include dockiteminfo as a public header and source file 3. Removed dockiteminfo files from panels/dock CMakeLists.txt and its subdirectories (appruntimeitem, multitaskview, tray) 4. Updated include statements in multiple dock components to use <dockiteminfo.h> instead of "dockiteminfo.h" 5. This refactoring centralizes dockiteminfo as a shared component accessible across different modules Log: Refactored dockiteminfo to be part of shared frame library Influence: 1. Verify dock functionality still works correctly after the move 2. Test application runtime items display properly in dock 3. Check multitask view functionality 4. Verify system tray items work as expected 5. Ensure all dock components can access dockiteminfo without compilation errors 6. Test build process to confirm no missing dependencies refactor: 将 dockiteminfo 移动到共享框架库 1. 将 dockiteminfo.h 和 dockiteminfo.cpp 从 panels/dock 移动到 frame 目录 2. 更新 frame 中的 CMakeLists.txt,将 dockiteminfo 添加为公共头文件和源 文件 3. 从 panels/dock 及其子目录(appruntimeitem、multitaskview、tray)的 CMakeLists.txt 中移除 dockiteminfo 文件 4. 更新多个 dock 组件中的包含语句,使用 <dockiteminfo.h> 替代 "dockiteminfo.h" 5. 此次重构将 dockiteminfo 集中为可在不同模块间访问的共享组件 Log: 重构 dockiteminfo 使其成为共享框架库的一部分 Influence: 1. 验证移动后 dock 功能是否正常工作 2. 测试应用程序运行时项目在 dock 中正确显示 3. 检查多任务视图功能 4. 验证系统托盘项目按预期工作 5. 确保所有 dock 组件都能访问 dockiteminfo 而无编译错误 6. 测试构建过程以确认没有缺失的依赖项
mhduiy
approved these changes
Apr 13, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
这个dockiteminfo,不应该放在dde-shell的开发库里吧,它只跟dock相关,dde-shell更通用些,基本上放所有组件都可能共用的, |
Contributor
Author
因为现在AI和 全局搜索也要实现在控制中心里面进行插件隐藏和显示,本来是准备修改DApplet暴露接口 但是改动有点大 |
Contributor
这玩意儿加了就不好删了,起码放在frame下面dock的目录里,必须要搞这个么?能不能通过dbus匿名搞着,或者新加个包,dock的开发包, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Refactored dockiteminfo to be part of shared frame library
Influence:
refactor: 将 dockiteminfo 移动到共享框架库
Log: 重构 dockiteminfo 使其成为共享框架库的一部分
Influence: