Skip to content

fix: use sigkill for wayland killClient() #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Jun 11, 2026
+7 −1
Merged

fix: use sigkill for wayland killClient() #1631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion panels/dock/taskmanager/treelandwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
#include "treelandwindow.h"
#include "abstractwindow.h"

#include <cstdint>

Check warning on line 8 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <cstdint> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <sys/types.h>

Check warning on line 9 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <sys/types.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <signal.h>

Check warning on line 10 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <signal.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include <QLoggingCategory>

Check warning on line 12 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QLoggingCategory> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include <private/qwaylandwindow_p.h>
#include <private/qwaylandnativeinterface_p.h>
Expand Down Expand Up @@ -201,12 +202,17 @@
m_foreignToplevelHandle->set_minimized();
}

void TreeLandWindow::killClient()

Check warning on line 205 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The function 'killClient' is never used.
{
m_foreignToplevelHandle->close();
const auto pid = m_foreignToplevelHandle->pid();
if (pid <= 0) {
qCWarning(waylandwindowLog()) << "Cannot find pid of window" << m_foreignToplevelHandle->appid() << m_foreignToplevelHandle->id();
return;
}
::kill(pid, SIGKILL);
}

void TreeLandWindow::setWindowIconGeometry(const QWindow* baseWindow, const QRect& gemeotry)

Check warning on line 215 in panels/dock/taskmanager/treelandwindow.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The function 'setWindowIconGeometry' is never used.
{
auto waylandWindow = dynamic_cast<QtWaylandClient::QWaylandWindow*>(baseWindow->handle());
if (waylandWindow->surface() == nullptr || gemeotry.isEmpty())
Expand Down
Loading