fix: close applet popup after bluetooth adaptor was removed by yixinshark · Pull Request #309 · linuxdeepin/dde-tray-loader

yixinshark · 2025-05-08T06:27:16Z

as title

Log: as title
Pms: BUG-285035

Summary by Sourcery

Bug Fixes:

Ensure the Bluetooth applet popup is hidden when no Bluetooth adapters are present

as title Log: as title Pms: BUG-285035

This reverts commit 82bc766.

sourcery-ai · 2025-05-08T06:28:46Z

Reviewer's Guide

The pull request updates the BluetoothItem class to automatically hide the Bluetooth applet when the noAdapter signal is emitted and the applet is currently visible. This is achieved by modifying the existing signal connection to use a lambda function that incorporates this new visibility check and hiding logic before re-emitting the noAdapter signal.

File-Level Changes

Change	Details	Files
Enhanced `noAdapter` signal handling to hide the Bluetooth applet.	Modified the connection for the `m_applet`'s `noAdapter` signal to execute a lambda function. The lambda function now checks if `m_applet` is visible. If `m_applet` is visible upon `noAdapter` signal emission, it is hidden by calling `m_applet->setVisible(false)`.	`plugins/dde-dock/bluetooth/bluetoothitem.cpp`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @yixinshark - I've reviewed your changes - here's some feedback:

Consider refactoring the lambda into a private slot on BluetoothItem for improved clarity, as it handles multiple responsibilities (UI update and signal emission).

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

deepin-ci-robot · 2025-05-08T06:29:20Z

deepin pr auto review

代码审查意见：

在BluetoothItem类的构造函数中，新增的lambda表达式用于处理noAdapter信号，但未对m_applet是否为空进行检查。如果m_applet为空，调用m_applet->isVisible()会导致空指针异常。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被禁用时，应该检查m_bluetoothItem是否为空，以避免潜在的空指针异常。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被禁用时，应该同时隐藏popupWidget，但代码中只检查了popupWidget是否存在，而没有检查m_bluetoothItem是否存在。如果m_bluetoothItem为空，调用m_bluetoothItem->popupApplet()会导致空指针异常。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被启用时，应该检查m_bluetoothItem是否为空，以避免潜在的空指针异常。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被启用时，应该同时显示popupWidget，但代码中只检查了popupWidget是否存在，而没有检查m_bluetoothItem是否存在。如果m_bluetoothItem为空，调用m_bluetoothItem->popupApplet()会导致空指针异常。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被禁用时，应该调用m_proxyInter->itemRemoved，而不是直接调用m_proxyInter->itemRemoved(this, BLUETOOTH_KEY)。这是因为itemRemoved函数可能需要更多的参数来正确地移除插件项。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被启用时，应该调用m_proxyInter->itemAdded，而不是直接调用m_proxyInter->itemAdded(this, BLUETOOTH_KEY)。这是因为itemAdded函数可能需要更多的参数来正确地添加插件项。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被禁用时，应该隐藏popupWidget，而不是直接调用popupWidget->setVisible(false)。这是因为popupWidget可能不是m_bluetoothItem的成员，而是通过其他方式获取的。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被启用时，应该显示popupWidget，而不是直接调用popupWidget->setVisible(true)。这是因为popupWidget可能不是m_bluetoothItem的成员，而是通过其他方式获取的。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被禁用时，应该调用m_bluetoothItem->requestHideApplet()，而不是直接调用m_bluetoothItem->requestHideApplet()。这是因为requestHideApplet函数可能需要更多的参数来正确地隐藏插件项。
在BluetoothPlugin类的refreshPluginItemsVisible函数中，当插件被启用时，应该调用m_bluetoothItem->requestShowApplet()，而不是直接调用m_bluetoothItem->requestShowApplet()。这是因为requestShowApplet函数可能需要更多的参数来正确地显示插件项。

deepin-ci-robot · 2025-05-08T07:05:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yixinshark added 2 commits May 8, 2025 14:26

fix: close applet popup after bluetooth adaptor was removed

f670f1b

as title Log: as title Pms: BUG-285035

Revert "fix: close applet popup after bluetooth adaptor was removed"

5e8d7aa

This reverts commit 82bc766.

sourcery-ai Bot reviewed May 8, 2025

View reviewed changes

18202781743 approved these changes May 8, 2025

View reviewed changes

yixinshark merged commit 4755169 into linuxdeepin:master May 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: close applet popup after bluetooth adaptor was removed#309

fix: close applet popup after bluetooth adaptor was removed#309
yixinshark merged 2 commits into
linuxdeepin:masterfrom
yixinshark:fix-removeBluetooth

yixinshark commented May 8, 2025 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented May 8, 2025

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

deepin-ci-robot commented May 8, 2025

Uh oh!

deepin-ci-robot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yixinshark commented May 8, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented May 8, 2025

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

deepin-ci-robot commented May 8, 2025

deepin pr auto review

Uh oh!

deepin-ci-robot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yixinshark commented May 8, 2025 •

edited by sourcery-ai Bot

Loading