refactor: reorder power mode options in performance controller#311
Merged
Conversation
1. Changed the order of power mode options in PerformanceModeController 2. Now shows High Performance first, followed by Balance Performance and Balanced mode 3. Matching property map was also reordered to maintain consistency 4. This change likely reflects a new priority order for power modes where performance is emphasized refactor: 性能控制器中电源模式选项重新排序 1. 修改了PerformanceModeController中电源模式选项的顺序 2. 现在首先显示高性能模式，然后是平衡性能和平衡模式 3. 匹配的属性映射也重新排序以保持一致性 4. 此变更可能反映了电源模式的新优先级顺序，其中性能被强调 pms: BUG-271001
Reviewer's GuideRefactors PerformanceModeController to reprioritize power mode options, displaying and mapping them in the order: High Performance, Balance Performance, Balanced, then Power Saver. Class Diagram: PerformanceModeController Power Mode Configuration UpdateclassDiagram
class PerformanceModeController {
+PerformanceModeController()
#_initializePowerModeData()
}
note for PerformanceModeController "The order of elements within internal data structures for power modes has been updated:\n\n powerModeList (QList<QPair<QString, QString>>), which dictates UI display order:\n - Previous order: Balanced, Balance Performance, High Performance, Power Saver.
- New order: High Performance, Balance Performance, Balanced, Power Saver.\n\n powerModeProperty (QMap<QString, QString>), a map of modes to their support property names:\n - Order of entries also realigned to match powerModeList for consistency."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mhduiy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
May 13, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: 性能控制器中电源模式选项重新排序
pms: BUG-271001
Summary by Sourcery
Enhancements: