fix: when hide plugin,setting button sholud be hided.#313
Conversation
as title. PMS-BUG-310045
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
deepin pr auto review代码审查意见:
综上所述,建议进行以下修改:
|
Reviewer's GuideIntroduces a Hide event handler in JumpSettingButton::event to clear hover state and refresh the UI, applied consistently across both the dde-dock and wirelesscasting plugin modules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -79,6 +79,10 @@ bool JumpSettingButton::event(QEvent* e) | |||
| m_hover = e->type() == QEvent::Enter; | |||
| update(); | |||
| break; | |||
There was a problem hiding this comment.
suggestion: Duplicate event logic across plugins—factor into shared component
Extract JumpSettingButton into a shared base or common library to avoid divergent implementations and ensure consistent grouping and Show handling.
|
recheck |
as title.
PMS-BUG-310045
Summary by Sourcery
Reset and redraw JumpSettingButton on QEvent::Hide to ensure the settings button hides correctly when its plugin is hidden.
Bug Fixes: