Skip to content

fix: when hide plugin,setting button sholud be hided. #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yixinshark merged 1 commit into from
May 16, 2025
Merged

fix: when hide plugin,setting button sholud be hided. #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/dde-dock/common/jumpsettingbutton.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ bool JumpSettingButton::event(QEvent* e)
m_hover = e->type() == QEvent::Enter;
update();
break;
case QEvent::Hide:
m_hover = false;
update();
break;
default:
break;
}
Expand Down
4 changes: 4 additions & 0 deletions ...e-network-display-ui/plugins/dock-wirelesscasting-plugin/src/widget/jumpsettingbutton.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ bool JumpSettingButton::event(QEvent* e)
m_hover = e->type() == QEvent::Enter;
update();
break;

@sourcery-ai sourcery-ai Bot May 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Duplicate event logic across plugins—factor into shared component

Extract JumpSettingButton into a shared base or common library to avoid divergent implementations and ensure consistent grouping and Show handling.

case QEvent::Hide:
m_hover = false;
update();
break;
default:
break;
}
Expand Down