fix: update appid of lastore daemon#316
Merged
Merged
Conversation
Resolve the issue of not being able to read dconfig correctly pms: TASK-377199
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideThis PR corrects the DConfig namespace for the lastore service and re-enables the logic that reads installation state from DConfig by removing obsolete preprocessor guards. Sequence Diagram: ShutdownPlugin Retrieving Lastore Update StatussequenceDiagram
participant SP as ShutdownPlugin
participant LDC as "m_lastoreDConfig (org.deepin.dde.lastore)"
SP->>LDC: isValid()
activate LDC
LDC-->>SP: bool isConfigValid
deactivate LDC
alt isConfigValid is true
SP->>LDC: value("updateStatus")
activate LDC
LDC-->>SP: QString updateStatusString
deactivate LDC
SP->>SP: Parse updateStatusString
SP->>SP: Determine menu item (e.g., "Ready to install updates")
end
Class Diagram: ShutdownPlugin Components for Lastore ConfigurationclassDiagram
class ShutdownPlugin {
-m_lastoreDConfig : DConfig*
+ShutdownPlugin(QObject *parent)
+itemContextMenu(const QString& itemKey) : const QString
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @mhduiy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
May 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the issue of not being able to read dconfig correctly
pms: TASK-377199
Summary by Sourcery
Fix DConfig misconfiguration preventing reading of lastore install status by updating the app id and enabling its configuration block in ShutdownPlugin.
Bug Fixes: