Skip to content

fix: update appid of lastore daemon#316

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dconfig
May 28, 2025
Merged

fix: update appid of lastore daemon#316
mhduiy merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dconfig

Conversation

@mhduiy

@mhduiy mhduiy commented May 28, 2025

Copy link
Copy Markdown
Contributor

Resolve the issue of not being able to read dconfig correctly

pms: TASK-377199

Summary by Sourcery

Fix DConfig misconfiguration preventing reading of lastore install status by updating the app id and enabling its configuration block in ShutdownPlugin.

Bug Fixes:

  • Use correct DConfig app id "org.deepin.dde.lastore" when creating the lastore configuration instance.
  • Remove conditional compilation guards to re-enable reading of lastore install status from DConfig.

Resolve the issue of not being able to read dconfig correctly

pms: TASK-377199
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • m_lastoreDConfig 的配置文件路径已从 "org.deepin.lastore" 更改为 "org.deepin.dde.lastore",需要确认新路径是否正确且配置文件存在。
  • 注释掉的代码块 #if 0 应该被移除或替换为适当的逻辑,以避免逻辑错误。

是否建议立即修改:

@mhduiy mhduiy requested a review from 18202781743 May 28, 2025 07:29
@sourcery-ai

sourcery-ai Bot commented May 28, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR corrects the DConfig namespace for the lastore service and re-enables the logic that reads installation state from DConfig by removing obsolete preprocessor guards.

Sequence Diagram: ShutdownPlugin Retrieving Lastore Update Status

sequenceDiagram
    participant SP as ShutdownPlugin
    participant LDC as "m_lastoreDConfig (org.deepin.dde.lastore)"

    SP->>LDC: isValid()
    activate LDC
    LDC-->>SP: bool isConfigValid
    deactivate LDC

    alt isConfigValid is true
        SP->>LDC: value("updateStatus")
        activate LDC
        LDC-->>SP: QString updateStatusString
        deactivate LDC
        SP->>SP: Parse updateStatusString
        SP->>SP: Determine menu item (e.g., "Ready to install updates")
    end
Loading

Class Diagram: ShutdownPlugin Components for Lastore Configuration

classDiagram
    class ShutdownPlugin {
        -m_lastoreDConfig : DConfig*
        +ShutdownPlugin(QObject *parent)
        +itemContextMenu(const QString& itemKey) : const QString
    }
Loading

File-Level Changes

Change Details Files
Updated the DConfig appid for the lastore daemon to match the new namespace
  • Changed the first argument of DConfig::create from org.deepin.lastore to org.deepin.dde.lastore
  • Changed the second argument of DConfig::create accordingly
plugins/dde-dock/shutdown/shutdownplugin.cpp
Reenabled configuration-based install status logic by removing preprocessor guards
  • Removed the #if 0 directive and the matching #endif around the DConfig read block
plugins/dde-dock/shutdown/shutdownplugin.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 2c0ab4e into linuxdeepin:master May 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants