fix: set page step for volume slider#346
Merged
Merged
Conversation
1. Added setPageStep(2) to volume slider initialization 2. This ensures consistent volume adjustment increments when using page up/down keys 3. Previously missing step value could cause inconsistent volume jumps 4. Matches expected behavior for system volume control fix: 设置音量滑块的页面步长 1. 在音量滑块初始化中添加了 setPageStep(2) 2. 确保在使用页面上下键时音量调整增量为一致值 3. 之前缺少步长值可能导致音量跳跃不一致 4. 符合系统音量控制的预期行为 Pms: BUG-327497
Reviewer's GuideInitialize the volume slider with a fixed page step to ensure consistent volume adjustment increments when using page up/down keys, aligning its behavior with system volume controls. Class diagram for updated SoundApplet volume slider initializationclassDiagram
class SoundApplet {
+void initUi()
}
class VolumeSlider {
+void setMinimum(int)
+void setMaximum(int)
+void setPageStep(int) %% Newly added in initialization
+Slider* slider()
}
SoundApplet --> VolumeSlider : uses
class SliderContainer {
+void setSlider(VolumeSlider*)
+void addBackground()
+void setButtonsSize(QSize)
}
SoundApplet --> SliderContainer : uses
VolumeSlider --> Slider : composition
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
18202781743
approved these changes
Aug 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 设置音量滑块的页面步长
Pms: BUG-327497
Summary by Sourcery
Bug Fixes: