fix: fix building warnings.#352
Merged
Merged
Conversation
as titile. Logs:
deepin pr auto review代码审查报告总体评价这是一系列关于Deepin Dock插件的代码修改，主要集中在添加Q_UNUSED宏来标记未使用的参数。这些修改有助于提高代码质量，消除编译器警告，并表明开发者有意忽略某些参数。 具体分析1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
具体改进建议
总结这些修改总体上是积极的，提高了代码质量并消除了编译器警告。建议在保持这些修改的基础上，进一步完善函数实现，添加必要的注释，并考虑使用const标记适当的成员函数。对于暂时未实现的函数，建议添加TODO注释以便后续跟踪。 |
Reviewer's GuideThis PR systematically silences compiler warnings by marking unused parameters and variables with Q_UNUSED, refines inline getter signatures, and corrects constructor initializer lists to match member order, improving code consistency and eliminating build-time warnings. Class diagram for updated getter signatures and member orderclassDiagram
class MonitorItemDelegate {
+int expandItemHeight() const
+int standardItemHeight() const
+int itemSpacing() const
}
class PluginItemDelegate {
+int itemHeight() const
+int itemSpacing() const
+void setItemHeight(int height)
+void setItemSpacing(int spacing)
}
class DeviceControlWidget {
+bool isExpand()
+void expandStateChanged(bool state)
}
class Monitor {
+bool canBrightness() const
}
Class diagram for PluginItem member order changeclassDiagram
class PluginItem {
QString m_itemKey
PluginsItemInterface *m_pluginsItemInterface
QMenu *m_menu
QScopedPointer<DockDBusProxy> m_dbusProxy
QTimer* m_tooltipTimer
QPointer<QWidget> m_tipsWidget
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider omitting parameter names in empty override definitions (e.g. void func(int) {}) or using [[maybe_unused]] instead of sprinkling Q_UNUSED everywhere to reduce noise and improve readability.
- Make sure initializer lists match the member declaration order in all classes to avoid warnings and keep the code consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider omitting parameter names in empty override definitions (e.g. void func(int) {}) or using [[maybe_unused]] instead of sprinkling Q_UNUSED everywhere to reduce noise and improve readability.
- Make sure initializer lists match the member declaration order in all classes to avoid warnings and keep the code consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
Aug 18, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as titile.
Logs:
Summary by Sourcery
Add Q_UNUSED macros and remove unnecessary qualifiers to suppress build warnings across loader and plugin modules
Enhancements:
Chores: