fix: Avoid datetime plugin seconds displayed not same with dcc's date…#358
Merged
Merged
Conversation
…time as title Log: as title Pms: BUG-289925
deepin pr auto review这段代码是关于日期时间插件的定时器设置部分，我来仔细审查并提供改进建议。 代码审查语法逻辑
代码质量
代码性能
代码安全
改进建议
m_refreshTimer->setInterval(500); // 修正拼写错误
// 整秒启动定时器，并增加更新频率，避免秒显示与控制中心显示不一致（控制中心500ms更新一次）
m_refreshTimer->setInterval(500);
// 计算距离下一个整秒的毫秒数，并在整秒时启动定时器
QTimer::singleShot(1000 - QTime::currentTime().msec(), [this]() {
// 立即更新时间字符串
updateCurrentTimeString();
// 启动定时器，每500ms更新一次
m_refreshTimer->start();
});
// 计算距离下一个整秒的毫秒数
int millisecondsToNextSecond = 1000 - QTime::currentTime().msec();
if (millisecondsToNextSecond < 0 || millisecondsToNextSecond > 1000) {
// 如果计算结果异常，使用默认值100ms
millisecondsToNextSecond = 100;
}
QTimer::singleShot(millisecondsToNextSecond, [this]() {
try {
updateCurrentTimeString();
m_refreshTimer->start();
} catch (...) {
// 处理可能的异常
qWarning() << "Failed to update current time string";
}
});
// 使用Qt::QueuedConnection确保在对象存在时执行
connect(this, &DatetimePlugin::destroyed, m_refreshTimer, &QTimer::stop);总结：这段代码的主要改进点在于修正拼写错误、增加适当的注释、考虑性能优化和增加错误处理。同时，可以进一步考虑更新频率的必要性，以及如何确保在对象生命周期内安全地使用定时器。 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusted the datetime plugin’s refresh mechanism to increase update frequency and align the display of seconds with the control center by synchronizing the timer start at whole seconds. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
18202781743
reviewed
Aug 28, 2025
| m_refershTimer->start(); | ||
| // 整秒启动定时器，并增加更新频率，避免秒显示与控制中心显示不一致（控制中心500ms更新一次） | ||
| m_refershTimer->setInterval(500); | ||
| QTimer::singleShot(1000 - QTime::currentTime().msec(), [this]() { |
Contributor
There was a problem hiding this comment.
这个singleShot本身也不是一个精确的时间，这样能保证时间是要一致的么，
18202781743
approved these changes
Aug 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…time
as title
Log: as title
Pms: BUG-289925
Summary by Sourcery
Ensure datetime plugin’s seconds display stays in sync with the control center by aligning the timer start to whole seconds and increasing its update frequency.
Bug Fixes: