feat: implement xdg-activation-v1 protocol for tray protocol handler#462
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
TAG Bot New tag: 2.0.33 |
Implement xdg-activation-v1 protocol support in the system tray protocol handler to provide proper XDG activation tokens for application window management, aligned with dde-shell implementation. This change moves the XdgActivation class to the dockpluginmanager-interface library for shared use across dock components. Key changes: 1. Add XdgActivation class to dockpluginmanager-interface library 2. Implement xdg-activation-v1 Wayland protocol client integration 3. Update tray protocol handler to use XDG activation token when activating SNI items 4. Add ProvideXdgActivationToken method to SNI DBus interface 5. Update library dependencies and CMake build configuration Log: Implemented XDG activation protocol for proper window focus management Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
18202781743
force-pushed
the
agent/agent/b3d3b5cf
branch
from
eeaba89 to
fee4de7
Compare
18202781743
changed the title
deepin pr auto review代码审查报告总体概述这个补丁主要添加了Wayland环境下的XdgActivation支持，用于处理系统托盘应用的激活令牌(token)请求。代码整体结构清晰，实现较为完整，但仍有一些可以改进的地方。 具体分析1. CMakeLists.txt 修改
建议：
2. DBus接口修改
建议：
3. sniprotocolhandler.cpp 修改
建议：
4. 新增XdgActivation相关文件
优点：
建议：
5. 安全性考虑
性能考虑
建议：
总结这个补丁实现了Wayland环境下的XdgActivation功能，代码整体质量较高，结构清晰。主要改进建议集中在错误处理、内存管理和代码结构优化方面。建议在合并前考虑上述建议，特别是添加超时机制和更完善的错误处理。 |
BLumia
approved these changes
Jun 8, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement xdg-activation-v1 protocol support in the system tray protocol handler to provide proper XDG activation tokens for application window management, aligned with dde-shell implementation. This change moves the XdgActivation class to the dockpluginmanager-interface library for shared use across dock components.
Key changes:
Log: Implemented XDG activation protocol for proper window focus management