Skip to content

chore: Add libssl-dev to Build-Depends in debian/control#404

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:fix-4-30
Apr 29, 2026
Merged

chore: Add libssl-dev to Build-Depends in debian/control#404
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:fix-4-30

Conversation

@dengzhongyuan365-dev
Copy link
Copy Markdown
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Apr 29, 2026

  • Included libssl-dev as a new build dependency to support SSL functionalities in the project.

Summary by Sourcery

Build:

  • Add libssl-dev to the Build-Depends in debian/control to ensure SSL-related code can be built.

- Included libssl-dev as a new build dependency to support SSL functionalities in the project.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds libssl-dev as a build dependency in the Debian packaging metadata to support SSL-related functionality during builds.

File-Level Changes

Change Details Files
Declare libssl-dev as a required build dependency in the Debian packaging configuration.
  • Update the Build-Depends field to include libssl-dev so that OpenSSL headers and libraries are available at build time
  • Ensure Debian packaging metadata reflects the SSL requirements of the project
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这段代码是一个针对 Debian 包构建配置文件(debian/control)的修改 diff,具体是在构建依赖(Build-Depends)列表中添加了 libssl-dev

以下是对此修改的详细审查意见:

1. 语法逻辑

  • 审查结果通过
  • 解释
    • debian/control 文件的语法要求字段之间用逗号分隔,且通常每个依赖项占一行(或以逗号结尾)。
    • 该 diff 正确地在列表中插入了一行 + libssl-dev,,保留了末尾的逗号,这符合 Debian 控制文件的语法规范,能够被 dpkg 和相关工具正确解析。

2. 代码质量

  • 审查结果良好
  • 解释
    • 排序规范:新添加的依赖项 libssl-dev 被插入到了 libsecret-1-devlibpoppler-cpp-dev 之间。在 Debian 打包规范中,通常建议依赖项按字母顺序排列,以便于维护和查找。
      • libsecret-1-dev
      • libssl-dev (新增)
      • libpoppler-cpp-dev
    • 检查字母顺序:poppler (p) 排在 secret (s) 之后,而 ssl (s) 排在 secret (s) 之后(因为 sec < ssl)。因此,libssl-dev 确实应该位于 libsecret-1-dev 之后。但紧接着的 libpoppler-cpp-dev (p) 在字母顺序上其实应该排在 libsecret-1-dev (s) 之前
    • 结论:虽然插入的位置符合当前的局部顺序逻辑(紧跟在 secret 之后),但从整体列表的严格字母排序来看,这个文件原本的排序可能就不完美,或者 libpoppler-cpp-dev 的位置比较特殊。如果遵循严格的字母排序,libpoppler-cpp-dev 应该在更前面。不过,既然是在现有列表中插入,保持上下文环境的连贯性也是可以接受的。

3. 代码性能

  • 审查结果不适用
  • 解释
    • 这是一个配置文件的修改,而非执行代码。libssl-dev 是一个开发库(头文件和静态链接库),它只影响软件的编译构建阶段,不会影响最终二进制文件的运行时性能(除非代码中链接了 OpenSSL 的特定性能优化特性,但这属于源码逻辑范畴)。

4. 代码安全

  • 审查结果需注意
  • 解释
    • 引入 OpenSSL:添加 libssl-dev 意味着该软件在构建时将链接 OpenSSL 库。OpenSSL 是一个广泛使用的加密库,用于处理 SSL/TLS 协议和加密算法。
    • 维护责任:引入 OpenSSL 意味着打包者需要关注 OpenSSL 的安全更新。如果 OpenSSL 暴露出新的漏洞(CVE),该软件在构建或运行时可能会受到影响。
    • 建议
      1. 确认源码中确实需要使用 SSL/TLS 功能(例如网络通信加密)。
      2. 检查是否可以通过系统现有的安全库(如 GnuTLS,如果已依赖)来实现功能,以减少依赖库的多样性,但 OpenSSL 是行业标准,通常是可以接受的。
      3. 确保在构建过程中链接的是系统提供的最新稳定版 OpenSSL,避免使用捆绑的旧版本库。

总结与改进建议

该修改在语法上是正确的,能够实现引入 OpenSSL 开发依赖的目的。

改进建议:

  1. 依赖项排序:建议检查整个 Build-Depends 列表,确保所有依赖项严格按字母顺序排列。如果 libpoppler-cpp-dev 没有特殊的排序理由,它应该移到 libsecret-1-dev 之前。
  2. 最小化依赖:确认是否真的需要 libssl-dev。如果只是使用了极少数功能,是否有更轻量的替代方案?不过对于加密需求,OpenSSL 通常是必须的。
  3. 版本限制:如果该软件对 OpenSSL 的版本有特定要求(例如必须 >= 1.1.0),建议在依赖项中指定版本号,例如 libssl-dev (>= 1.1.0),以确保构建环境的安全性。

最终结论:该修改是安全且合理的,只需注意后续对 OpenSSL 安全漏洞的跟进。

@dengzhongyuan365-dev
Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot deepin-bot Bot merged commit bdc8358 into linuxdeepin:master Apr 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants