Skip to content

chore: [log]More logs#282

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
re2zero:bugfix
May 23, 2025
Merged

chore: [log]More logs#282
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
re2zero:bugfix

Conversation

@re2zero
Copy link
Copy Markdown
Contributor

@re2zero re2zero commented May 22, 2025

Add more logs for log coverage.

Log: Add more logs.

Summary by Sourcery

Enhancements:

  • Instrument core components (MainWindow, pages, dialogs, managers, plugins, threads and utilities) with debug/info/warning logs to trace initialization, user interactions, file operations, thread activity, error conditions and lifecycle events.

Add more logs for log coverage.

Log: Add more logs.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented May 22, 2025

Reviewer's Guide

This PR instruments the entire codebase with additional qDebug/qInfo/qWarning/qCritical statements to enhance log coverage and traceability, inserting logs at key lifecycle points (constructors, destructors), user actions, plugin and job operations, UI flows, utility functions, and error paths.

File-Level Changes

Change Details Files
Instrumentation of MainWindow class
  • Added debug logs at constructor start/end
  • Instrumented UI initialization and timer events
  • Logged path permission checks and thread operations
  • Logged event handling (timerEvent, closeEvent) and page switching
  • Inserted logs in destructor and cleanup sequence
src/source/mainwindow.cpp
Enhanced startup and application lifecycle logging
  • Logged application startup arguments and environment setup
  • Logged DTK property initialization and translator loading
  • Logged DBus service registration (standard and WPS modes)
  • Instrumented quit and focus events in CompressorApplication and DBus adaptor
src/main.cpp
src/source/compressorapplication.cpp
src/source/common/dbusadpator.cpp
Instrumented archive job and manager operations
  • Logged plugin discovery, loading and filtering in PluginManager
  • Logged interface creation and load/create operations in ArchiveManager
  • Added lifecycle logs in ArchiveJob, SingleJob (start, pause, continue, kill, finish)
  • Instrumented batch extract job start and subjob transitions
src/source/common/pluginmanager.cpp
src/source/common/plugin.cpp
src/source/archivemanager/archivejob.cpp
src/source/archivemanager/singlejob.cpp
src/source/archivemanager/batchjob.cpp
src/source/archivemanager/archivemanager.cpp
Added logging to UI dialogs and pages
  • Instrumented constructors, destructors and init methods of dialogs (OpenWithDialog, SettingDialog, ProgressDialog, CommentProgressDialog)
  • Logged user interactions (button clicks, drag/drop events) in pages and dialogs
  • Added navigation and signal emission logs in HomePage, CompressPage, UnCompressPage, SuccessPage, FailurePage, ProgressPage
  • Logged file selection and context menu actions
src/source/dialog/openwithdialog/openwithdialog.cpp
src/source/dialog/settingdialog.cpp
src/source/dialog/progressdialog.cpp
src/source/dialog/commentprogressdialog.cpp
src/source/dialog/popupdialog.cpp
src/source/page/homepage.cpp
src/source/page/compresspage.cpp
src/source/page/compresssettingpage.cpp
src/source/page/uncompresspage.cpp
src/source/page/successpage.cpp
src/source/page/failurepage.cpp
src/source/page/progresspage.cpp
src/source/page/loadingpage.cpp
Extended logging in utility modules
  • Logged MIME type detection and correction in mimetypes and DMimeDatabase
  • Instrumented path control, config/cache path resolution in DFMStandardPaths
  • Added debug output in UiTools helpers and CalculateSizeThread operations
  • Logged event log initialization and writes in EventLogUtils
  • Instrumented file watching in OpenFileWatcher
src/source/common/mimetypes.cpp
src/source/dialog/openwithdialog/dmimedatabase.cpp
src/source/common/uitools.cpp
src/source/common/calculatesizethread.cpp
src/source/common/eventlogutils.cpp
src/source/dialog/openwithdialog/dfmstandardpaths.cpp
src/source/common/openFileWatcher.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero
Copy link
Copy Markdown
Contributor Author

re2zero commented May 23, 2025

/merge

@deepin-bot deepin-bot bot merged commit 1f4316e into linuxdeepin:develop/snipe May 23, 2025
14 checks passed
@re2zero re2zero deleted the bugfix branch May 23, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants