Merged
Conversation
Add more logs. 74.92% Log: More logs.
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideThis PR introduces comprehensive logging across the codebase by injecting qDebug, qInfo, and qWarning statements at key points in core workflows, job lifecycles, UI initialization and event handling, plugin and MIME management, and utility methods to improve visibility into runtime behavior. Class diagram for logging additions in job classesclassDiagram
class CreateJob {
+doWork()
+doKill()
+cleanCompressFileCancel()
<<logging added>>
}
class ExtractJob {
+ExtractJob(...)
+~ExtractJob()
+doWork()
<<logging added>>
}
class DeleteJob {
+DeleteJob(...)
+~DeleteJob()
+doWork()
<<logging added>>
}
class RenameJob {
+RenameJob(...)
+~RenameJob()
+doWork()
<<logging added>>
}
class OpenJob {
+OpenJob(...)
+~OpenJob()
+doWork()
+slotFinished(...)
<<logging added>>
}
class UpdateJob {
+UpdateJob(...)
+~UpdateJob()
+start()
+doWork()
<<logging added>>
}
class CommentJob {
+CommentJob(...)
+~CommentJob()
+doWork()
<<logging added>>
}
class ComplexJob {
+ComplexJob(...)
+~ComplexJob()
+doPause()
+doContinue()
+doKill()
+slotHandleSingleJobProgress(...)
+slotHandleSingleJobCurFileName(...)
<<logging added>>
}
class ConvertJob {
+ConvertJob(...)
+~ConvertJob()
+start()
+slotHandleExtractFinished()
<<logging added>>
}
class StepExtractJob {
+StepExtractJob(...)
+~StepExtractJob()
+start()
+slotHandleExtractFinished()
+doKill()
<<logging added>>
}
Class diagram for logging additions in utility and manager classesclassDiagram
class UiTools {
+UiTools(...)
+~UiTools()
+getConfigPath()
+renderSVG(...)
+humanReadableSize(...)
+isExistMimeType(...)
+readConf()
+toShortString(...)
+createInterface(...)
+transSplitFileName(...)
+handleFileName(...)
+isLocalDeviceFile(...)
+removeSameFileName(...)
+isWayland()
<<logging added>>
}
class ArchiveManager {
+get_instance()
+destory_instance()
+createArchive(...)
+loadArchive(...)
+addFiles(...)
+extractFiles(...)
+extractFiles2Path(...)
+deleteFiles(...)
+renameFiles(...)
+batchExtractFiles(...)
+openFile(...)
+updateArchiveCacheData(...)
+updateArchiveComment(...)
+convertArchive(...)
+pauseOperation()
+continueOperation()
+cancelOperation()
+getCurFilePassword()
+currentStatus()
+slotJobFinished()
<<logging added>>
}
class MimeAppsWorker {
+~MimeAppsWorker()
+initConnect()
+startWatch()
+handleDirectoryChanged(...)
+handleFileChanged(...)
+updateCache()
+writeData(...)
+readData(...)
<<logging added>>
}
class MimesAppsManager {
+getMimeTypeByFileName(...)
+getDefaultAppByFileName(...)
+getDefaultAppByMimeType(...)
+getDefaultAppDisplayNameByMimeType(...)
+getDefaultAppDisplayNameByGio(...)
+getDefaultAppDesktopFileByMimeType(...)
+getRecommendedAppsByGio(...)
+getApplicationsFolders()
+getMimeAppsCacheFile()
+getMimeInfoCacheFilePath()
+getMimeInfoCacheFileRootPath()
+getDesktopFilesCacheFile()
+getDesktopIconsCacheFile()
+getDesktopFiles()
+getDDEMimeTypeFile()
+getDesktopObjs()
+initMimeTypeApps()
+lessByDateTime(...)
+removeOneDupFromList(...)
<<logging added>>
}
class MimeTypeDisplayManager {
+initConnect()
+displayName(...)
+displayNameToEnum(...)
+defaultIcon(...)
+displayNames()
+readlines(...)
+loadSupportMimeTypes()
+supportArchiveMimetypes()
+supportVideoMimeTypes()
<<logging added>>
}
Class diagram for logging additions in UI and dialog classesclassDiagram
class UnCompressView {
+setArchivePath(...)
+setDefaultUncompressPath(...)
+mousePressEvent(...)
+mouseMoveEvent(...)
+clearDragData()
+mouseDoubleClickEvent(...)
+initUI()
+initConnections()
+calDirItemCount(...)
+handleDoubleClick(...)
+refreshDataByCurrentPath()
+refreshDataByCurrentPathChanged()
+addNewFiles(...)
+getCurPath()
+setModifiable(...)
+isModifiable()
+clear()
+getCurPathFiles()
+getSelEntry()
+extract2Path(...)
+calEntrySizeByParentPath(...)
+slotDragFiles(...)
+slotShowRightMenu(...)
+slotExtract()
+slotExtract2Here()
+slotDeleteFile()
+slotRenameFile()
+slotOpen()
+slotOpenStyleClicked()
+slotPreClicked()
<<logging added>>
}
class OpenWithDialogListItem {
+OpenWithDialogListItem(...)
+~OpenWithDialogListItem()
+setChecked(...)
+text()
+resizeEvent(...)
+enterEvent(...)
+leaveEvent(...)
+paintEvent(...)
<<logging added>>
}
class OpenWithDialogListSparerItem {
+OpenWithDialogListSparerItem(...)
+~OpenWithDialogListSparerItem()
<<logging added>>
}
class OpenWithDialog {
+getOpenStyle(...)
+resizeEvent(...)
+eventFilter(...)
+showOpenWithDialog(...)
+getProgramPathByExec(...)
+init()
+initConnections()
+initData()
+checkItem(...)
+createItem(...)
+slotUseOtherApplication(...)
<<logging added>>
}
class CompressSettingPage {
+initUI()
+initConnections()
+setTypeImage(...)
+checkFileNameVaild(...)
+setEncryptedEnabled(...)
+slotEchoModeChanged(...)
+setListEncryptionEnabled(...)
+setSplitEnabled(...)
+refreshCompressLevel(...)
+setCommentEnabled(...)
+checkCompressOptionValid()
+checkFile(...)
+showWarningDialog(...)
+setDefaultName(...)
+initConfig()
+slotShowRightMenu(...)
+slotTypeChanged(...)
+slotRefreshFileNameEdit()
+slotAdvancedEnabled(...)
+slotSplitEdtEnabled()
+slotCompressClicked()
+slotCommentTextChanged()
+slotPasswordChanged()
+getCompressBtn()
+getComment()
+eventFilter(...)
+isOrderMode()
+getClickLbl()
<<logging added>>
}
class TypeLabel {
+TypeLabel(...)
+~TypeLabel()
+mousePressEvent(...)
+paintEvent(...)
+focusInEvent(...)
+focusOutEvent(...)
<<logging added>>
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
lzwind
approved these changes
Jul 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more logs. 74.92%
Log: More logs.
Summary by Sourcery
Add extensive logging across the application to improve traceability of operations, including job lifecycle events, UI interactions, plugin management, file and configuration handling.
Enhancements: