Skip to content

fix: update translations#333

Merged
max-lvs merged 1 commit intolinuxdeepin:release/eaglefrom
LiHua000:release/eagle
Dec 9, 2025
Merged

fix: update translations#333
max-lvs merged 1 commit intolinuxdeepin:release/eaglefrom
LiHua000:release/eagle

Conversation

@LiHua000
Copy link
Copy Markdown
Contributor

@LiHua000 LiHua000 commented Dec 9, 2025

Log: as title

Bug: https://pms.uniontech.com/bug-view-343117.html

Summary by Sourcery

Update and reconnect UI translations for archive corruption and password dialogs across locales.

Bug Fixes:

  • Restore missing Chinese translations for damaged-archive and password-required prompts.
  • Ensure common dialog button strings (Skip, Replace, Cancel, OK, Apply to all) are correctly mapped to new query interfaces across translation files.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这是一个Qt翻译文件(.ts)的更新diff,主要涉及多语言支持的修改。我来分析一下:

  1. 语法逻辑:
  • 修改符合Qt .ts文件的标准格式
  • location标签正确指向源代码位置
  • context和message标签结构完整
  • translation标签的格式正确
  1. 代码质量:
  • 所有修改都是将"vanished"类型的翻译改为正常翻译
  • 添加了新的location信息,提高了代码的可维护性
  • 保持了翻译文本的一致性
  1. 代码性能:
  • 作为翻译文件,不会影响程序运行性能
  • location信息的添加有助于调试和维护
  1. 代码安全:
  • 修改不涉及安全相关的问题
  • 翻译内容都是纯文本,没有安全风险

改进建议:

  1. 建议统一所有语言版本的翻译格式,确保一致性
  2. 对于新添加的location信息,建议验证这些路径是否准确
  3. 建议添加翻译审查流程,确保不同语言版本的翻译质量
  4. 可以考虑添加翻译注释,帮助翻译人员理解上下文

总体来说,这是一个良好的翻译文件更新,主要改进了翻译的可用性和可维护性。修改内容清晰,格式规范,没有发现明显的问题。

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Dec 9, 2025

Reviewer's Guide

Aligns translation entries with new query dialogs by adding missing contexts to the generic TS file and re‑enabling/connecting existing Chinese translations to the new 3rdparty/interface/queries.cpp locations for corruption, password, and conflict dialogs.

File-Level Changes

Change Details Files
Add translation contexts for new query dialogs used by 3rdparty/interface/queries.cpp.
  • Introduce LoadCorruptQuery context with messages for damaged archive handling and associated buttons.
  • Introduce PasswordNeededQuery context for encrypted archive password prompt.
translations/deepin-compressor.ts
Re-enable and bind existing Simplified and Traditional Chinese translations to the new query dialog message locations.
  • Remove type="vanished" from LoadCorruptQuery and PasswordNeededQuery messages so they become active again.
  • Add new location entries pointing to ../3rdparty/interface/queries.cpp for archive corruption and password prompts in all zh TS files.
  • Share button strings (Skip, Replace, Cancel, OK, Apply to all) between popupdialog.cpp and queries.cpp through additional location tags.
translations/deepin-compressor_zh_CN.ts
translations/deepin-compressor_zh_HK.ts
translations/deepin-compressor_zh_TW.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiHua000, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 3abefdd into linuxdeepin:release/eagle Dec 9, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants