[deepin-compressor] Updates for project Deepin Archive Manager#379
Closed
transifex-integration[bot] wants to merge 1 commit intomasterfrom
Closed
[deepin-compressor] Updates for project Deepin Archive Manager#379transifex-integration[bot] wants to merge 1 commit intomasterfrom
transifex-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
100% translated source file: 'deepin-compressor.ts' on 'es'.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: transifex-integration[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideUpdates the Spanish Qt translation file for Deepin Archive Manager to sync with current source strings: adds translations for new messages, refines existing phrasing, fills previously unfinished entries, and keeps the TS structure consistent with upstream (including dialog/button texts and settings labels). File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The XML header and root TS tags were collapsed onto a single line; consider keeping them formatted on separate lines to stay consistent with the other translation files and preserve readability for future manual edits and merges.
- Some Spanish strings mix terminology for 'file' ('archivo' vs 'fichero') and there are a couple of accent issues (e.g. 'fué' → 'fue'); it would be good to normalize terminology and spelling across the updated messages for a more consistent UI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The XML header and root TS tags were collapsed onto a single line; consider keeping them formatted on separate lines to stay consistent with the other translation files and preserve readability for future manual edits and merges.
- Some Spanish strings mix terminology for 'file' ('archivo' vs 'fichero') and there are a couple of accent issues (e.g. 'fué' → 'fue'); it would be good to normalize terminology and spelling across the updated messages for a more consistent UI.
## Individual Comments
### Comment 1
<location path="translations/deepin-compressor_es.ts" line_range="1359-1363" />
<code_context>
</message>
<message>
<location filename="../src/source/dialog/settingdialog.cpp" line="132"/>
<source>Clear All</source>
<translation>Limpiar todos</translation>
</message>
- <message>
</code_context>
<issue_to_address>
**suggestion (typo):** Improve the grammar of "Limpiar todos".
`Limpiar todos` suena algo extraño en este contexto; lo habitual en interfaces es usar el singular neutro. Considera `Borrar todo` o `Limpiar todo`, que resultan más naturales para traducir "Clear All".
```suggestion
<message>
<location filename="../src/source/dialog/settingdialog.cpp" line="132"/>
<source>Clear All</source>
<translation>Borrar todo</translation>
</message>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
1359
to
1363
| <message> | ||
| <location filename="../src/source/dialog/settingdialog.cpp" line="132"/> | ||
| <source>Clear All</source> | ||
| <translation>Limpiar todos</translation> | ||
| </message> |
There was a problem hiding this comment.
suggestion (typo): Improve the grammar of "Limpiar todos".
Limpiar todos suena algo extraño en este contexto; lo habitual en interfaces es usar el singular neutro. Considera Borrar todo o Limpiar todo, que resultan más naturales para traducir "Clear All".
Suggested change
| <message> | |
| <location filename="../src/source/dialog/settingdialog.cpp" line="132"/> | |
| <source>Clear All</source> | |
| <translation>Limpiar todos</translation> | |
| </message> | |
| <message> | |
| <location filename="../src/source/dialog/settingdialog.cpp" line="132"/> | |
| <source>Clear All</source> | |
| <translation>Borrar todo</translation> | |
| </message> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following localization files have been updated:
Details
Files
Summary by Sourcery
Update Spanish localization strings for Deepin Archive Manager UI and dialogs.
Enhancements: