refactor: remove EventLogUtils references from main application and a…#384
Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom Apr 16, 2026
Merged
Conversation
…rchive management - Removed EventLogUtils logging calls from main.cpp, archivemanager.cpp, and mainwindow.cpp to streamline the codebase. - Deleted associated enum values from eventlogutils.h to clean up unused code. This change simplifies the logging mechanism and reduces dependencies on EventLogUtils. TASK: https://pms.uniontech.com/task-view-388231.html
There was a problem hiding this comment.
Sorry @dengzhongyuan365-dev, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
lzwind
previously approved these changes
Apr 13, 2026
Contributor
Author
|
/forcemerge |
c2cbe2b to
eb65844
Compare
deepin pr auto review这段代码的变更主要是移除了 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
5. 改进建议
6. 其他观察
总结这次代码变更主要是清理不再使用的日志记录代码,整体是合理的。但需要确保:
如果以上条件都满足,这次变更是安全的,可以合并。 |
Contributor
Author
|
/forcemerge |
lzwind
approved these changes
Apr 16, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rchive management
This change simplifies the logging mechanism and reduces dependencies on EventLogUtils.
TASK: https://pms.uniontech.com/task-view-388231.html