chore: [log]More logs#142
Merged
Merged
Conversation
Add more logs for log coverage. Log: Add more logs.
deepin pr auto review关键摘要:
是否建议立即修改: 建议立即修改的原因是，虽然添加调试信息有助于开发过程中的问题定位，但过多的调试信息在生产环境中可能会泄露敏感信息，影响性能，并可能被恶意用户利用。因此，建议在生产环境中移除或禁用这些调试信息。同时，对于可能引发空指针异常的代码，应该进行相应的空值检查，以避免程序崩溃。 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @re2zero - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR instruments the entire codebase with extensive logging by inserting qDebug/qInfo/qWarning statements across core model classes, service operations, filesystem handlers, and UI components to improve runtime observability and debugging. Updated Class Diagram for ProbeThreadclassDiagram
class ProbeThread {
-QList<DeviceInfo> m_inforesult
-QMap<QString, Device> m_deviceMap
-LVMInfo m_lvmInfo
-LUKSMap m_luksInfo
+ProbeThread(QObject* parent)
+void probeDeviceInfo()
}
Updated Class Diagram for DeviceListWidgetclassDiagram
class DeviceListWidget {
-QString m_curChooseDevicePath
-QString m_curChooseVGName
-DmTreeview* m_treeView
+DeviceListWidget(QWidget* parent)
+~DeviceListWidget()
-void initUi()
-void initConnection()
-void treeMenu(const QPoint& pos)
-void onDiskInfoClicked()
-void onDiskCheckHealthClicked()
-void onDiskBadSectorsClicked()
-void onCreatePartitionTableClicked()
-void onPartitionErrorCheckClicked()
-void onHidePartitionClicked()
-void onShowPartitionClicked()
-void onDeletePartitionClicked()
-void onDeleteVGClicked()
-void onCreateLVClicked()
-void onDeleteLVClicked()
-void onVGDeleteMessage(const QString& vgMessage)
-void onLVDeleteMessage(const QString& lvMessage)
-void setCurDevicePath(const QString& devPath)
-void setCurVGName(const QString& vgName)
-void onUpdateDeviceInfo()
}
Updated Class Diagram for NTFS Filesystem HandlerclassDiagram
namespace DiskManager {
class NTFS {
-FS_Limits m_fsLimits
+FS getFilesystemSupport()
+void setUsedSectors(Partition& partition)
+void readLabel(Partition& partition)
+bool writeLabel(const Partition& partition)
+void readUuid(Partition& partition)
+bool writeUuid(const Partition& partition)
+bool create(const Partition& newPartition)
+bool checkRepair(const Partition& partition)
+bool checkRepair(const QString& devpath)
}
}
Updated Class Diagram for DiskManagerServiceclassDiagram
class DiskManagerService {
-PartedCore* m_partedcore
-QString m_frontEndDBusName
+DiskManagerService(const QString& frontEndDBusName, QObject* parent)
+DeviceInfo getDeviceinfo()
+bool format(const QString& fstype, const QString& name)
-bool checkAuthorization()
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
lzwind
approved these changes
May 26, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more logs for log coverage.
Log: Add more logs.
Summary by Sourcery
Add comprehensive logging throughout the codebase to improve traceability of operations and state changes.
Enhancements: