fix: block model shows 'UnKnow'#155
Merged
Merged
Conversation
Reviewer's GuideIntroduced a new fallback step to retrieve the disk model via udevadm when smartctl and lshw both fail, parsing the ID_MODEL field and early-returning on success, and logging a warning before falling back to the existing “UnKnow” default. Sequence diagram for updated disk model retrieval processsequenceDiagram
participant DeviceStorage
participant smartctl
participant lshw
participant udevadm
DeviceStorage->>smartctl: Try to get model info
alt smartctl returns model
DeviceStorage-->>DeviceStorage: Use model from smartctl
else smartctl fails
DeviceStorage->>lshw: Try to get model info
alt lshw returns model
DeviceStorage-->>DeviceStorage: Use model from lshw
else lshw fails
DeviceStorage->>udevadm: Try to get ID_MODEL
alt udevadm returns ID_MODEL
DeviceStorage-->>DeviceStorage: Use model from udevadm
else udevadm fails
DeviceStorage-->>DeviceStorage: Set model to "UnKnow"
end
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
cannot obtain model info from either smartctl nor lshw commands, try with udevadm command to obtain ID_MODEL field. Log: fix block model missing. Bug: https://pms.uniontech.com/bug-view-322579.html
deepin pr auto review关键摘要:
是否建议立即修改: |
max-lvs
approved these changes
Jul 4, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cannot obtain model info from either smartctl nor lshw commands, try
with udevadm command to obtain ID_MODEL field.
Log: fix block model missing.
Bug: https://pms.uniontech.com/bug-view-322579.html
Summary by Sourcery
Use udevadm to retrieve block device model as a fallback when smartctl and lshw fail, and emit a warning if still unavailable.
Bug Fixes:
Enhancements: