fix: Fix app crash when exiting#153
Merged
Merged
Conversation
Do not log in destructors of global variables, which can cause crashes. Log: Fix app crash when exiting Bug: https://pms.uniontech.com/bug-view-322249.html
Reviewer's GuideDisabled logging in the BlockSpecial destructor to prevent application crashes on exit. Class diagram for BlockSpecial destructor logging changeclassDiagram
class BlockSpecial {
+BlockSpecial(const QString &name)
-~BlockSpecial()
+clearCache()
-QString m_name
}
%% Note: Logging statement removed from destructor to prevent crash
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @wangrong1069 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review代码审查意见: .gitignore 文件
service/diskoperation/blockspecial.cpp 文件
代码质量
代码性能
代码安全
总体来说,这些改动主要是为了提高代码的可维护性和减少潜在的运行时错误。建议在合并这些更改之前,与团队成员进行讨论,以确保这些更改不会对现有系统产生负面影响。 |
lzwind
approved these changes
Jul 1, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
Contributor
|
This pr cannot be merged! (status: unstable) |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not log in destructors of global variables, which can cause crashes.
Log: Fix app crash when exiting
Bug: https://pms.uniontech.com/bug-view-322249.html
Summary by Sourcery
Bug Fixes: