chore: Update deepin-manual resources#157
Merged
Merged
Conversation
- Update deepin-manaual resources log: Update deepin-manaual resources
deepin pr auto review代码审查结果如下：
总体来说，文件内容较为完整，但可能需要进一步优化和检查以确保代码质量和用户体验。 |
Reviewer's GuideThis PR reorganizes and updates the disk manager documentation by cleaning up outdated figure references, standardizing filenames, and introducing brand-new, comprehensive localized manual files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:
- The removal of image references (e.g.,
![0|startverify],![0|format]) will break figure rendering—please confirm those deletions are intentional or restore the correct links. - The newly added locale docs use a
p_disk-manager.mdfilename prefix instead of the existingdisk-manager.mdconvention—please align naming or update your docs config so these files load correctly. - There are minor formatting inconsistencies (list markers and indentation) across the added translation files—please run a markdown formatter to keep styling uniform.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The removal of image references (e.g., `![0|startverify]`, `![0|format]`) will break figure rendering—please confirm those deletions are intentional or restore the correct links.
- The newly added locale docs use a `p_disk-manager.md` filename prefix instead of the existing `disk-manager.md` convention—please align naming or update your docs config so these files load correctly.
- There are minor formatting inconsistencies (list markers and indentation) across the added translation files—please run a markdown formatter to keep styling uniform.
## Individual Comments
### Comment 1
<location> `application/assets/deepin-diskmanager/disk-manager/en_US/p_disk-manager.md:152` </location>
<code_context>
+
+1. On the Disk Utility interface, select a disk or partition and click the Wipe  icon on the top toolbar.
+2. A wiping interface pops up. Fill in the name and select the file system and security option. AES / SM4 encryption is supported. There are three security options, namely Fast, Secure and Advanced, with the Fast option as the default.
+ - Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probabality.
+ - Secure: It is a one-time secure wipe that complies with NIST 800-88 and writes 0, 1, and random data to the entire disk once. You will not be able to recover files, and the process will be slow.
+ - Advanced: There are two wiping methods, namely DoD 5220.22-M and Gutmann. It writes 0, 1, and random data to the entire disk several times. You can set the number of times to wipe disks and overwrite data, but the process will be very slow.
</code_context>
<issue_to_address>
Typo: 'probabality' should be 'probability'.
Please update 'probabality' to 'probability' in the text.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
- Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probabality.
=======
- Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probability.
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `application/assets/deepin-diskmanager/disk-manager/zh_TW/p_disk-manager.md:298` </location>
<code_context>
+
+掛載邏輯卷與掛載分區操作類似，詳細操作請參考磁碟管理的 [掛載分區](#掛載分區)。
+
+#### 移除邏輯卷
+
+移除邏輯卷組與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。
</code_context>
<issue_to_address>
Section heading may be confusing: '移除邏輯卷組與移除分區操作類似'.
The section discusses removing a logical volume, but the heading and text mention removing a volume group. Please update the wording for accuracy.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
#### 移除邏輯卷
移除邏輯卷組與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。
=======
#### 移除邏輯卷
移除邏輯卷與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| 1. On the Disk Utility interface, select a disk or partition and click the Wipe  icon on the top toolbar. | ||
| 2. A wiping interface pops up. Fill in the name and select the file system and security option. AES / SM4 encryption is supported. There are three security options, namely Fast, Secure and Advanced, with the Fast option as the default. | ||
| - Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probabality. |
There was a problem hiding this comment.
issue (typo): Typo: 'probabality' should be 'probability'.
Please update 'probabality' to 'probability' in the text.
Suggested change
| - Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probabality. | |
| - Fast: It only deletes the partition info without erasing the files on the disk. Disk recover tools may recover the files with a certain probability. |
Comment on lines
+298
to
+300
| #### 移除邏輯卷 | ||
|
|
||
| 移除邏輯卷組與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。 |
There was a problem hiding this comment.
suggestion: Section heading may be confusing: '移除邏輯卷組與移除分區操作類似'.
The section discusses removing a logical volume, but the heading and text mention removing a volume group. Please update the wording for accuracy.
Suggested change
| #### 移除邏輯卷 | |
| 移除邏輯卷組與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。 | |
| #### 移除邏輯卷 | |
| 移除邏輯卷與移除分區操作類似，詳細操作請參考磁碟管理的 [移除分區](#移除分區)。 |
lzwind
approved these changes
Jul 8, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log: Update deepin-manaual resources
Summary by Sourcery
Update deepin-diskmanager manual resources by reorganizing file names, cleaning up image references, and adding complete localized documentation pages.
Enhancements:
Documentation: