feat: Enhance time tracking in DiskBadSectorsDialog#161
Merged
Conversation
Changes: 1. Added real-time tracking for elapsed time during disk checks. 2. Implemented pause functionality to accurately account for time spent paused. 3. Updated progress calculation based on actual elapsed time. Log: Improved time management for disk sector checks, providing a more accurate user experience. Bug: https://pms.uniontech.com/bug-view-324195.html
deepin pr auto review代码审查意见:
|
Reviewer's GuideThis PR adds real-time tracking of disk check durations, including pause/resume support, and updates the timeout handler to compute progress and remaining time based on actual elapsed time rather than fixed estimates. Class diagram for updated DiskBadSectorsDialog time trackingclassDiagram
class DiskBadSectorsDialog {
+void onStartVerifyButtonClicked()
+void onCheckTimeOut()
+void onStopButtonClicked()
+void onContinueButtonClicked()
+void onAgainVerifyButtonClicked()
+void onResetButtonClicked()
-- Time tracking fields --
qint64 m_realStartTime
qint64 m_pauseStartTime
qint64 m_totalPausedTime
bool m_isPaused
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
max-lvs
approved these changes
Jul 22, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Log: Improved time management for disk sector checks, providing a more accurate user experience.
Bug: https://pms.uniontech.com/bug-view-324195.html
Summary by Sourcery
Implement high-precision time tracking in DiskBadSectorsDialog by using QDateTime for actual elapsed time, integrate pause/resume support, and update progress and remaining time estimations accordingly
New Features:
Bug Fixes:
Enhancements: