Skip to content

fix: Disable bad sector detection for SSD devices#165

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:release/1071from
itsXuSt:1071
Aug 7, 2025
Merged

fix: Disable bad sector detection for SSD devices#165
deepin-bot[bot] merged 1 commit into
linuxdeepin:release/1071from
itsXuSt:1071

Conversation

@itsXuSt
Copy link
Copy Markdown
Contributor

@itsXuSt itsXuSt commented Aug 7, 2025

Changes:

  1. Added a condition to disable the bad sector detection feature for SSD devices in the device list widget.

Log: Improved user experience by preventing unnecessary checks on SSDs.

Bug: https://pms.uniontech.com/bug-view-327485.html

Summary by Sourcery

Disable the bad sector detection option for SSD devices in the device list widget to prevent unnecessary checks and improve user experience.

Bug Fixes:

  • Disable bad sector detection action for SSD devices in the context menu

Enhancements:

  • Improve user experience by hiding irrelevant checks on SSD drives

Changes:
1. Added a condition to disable the bad sector detection feature for SSD devices in the device list widget.

Log: Improved user experience by preventing unnecessary checks on SSDs.

Bug: https://pms.uniontech.com/bug-view-327485.html
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Added a check in DeviceListWidget::treeMenu to disable the bad sector detection action for SSDs by disabling the Verify/Repair menu item when the device media type is “SSD”.

Class diagram for DeviceListWidget changes

classDiagram
    class DeviceListWidget {
        void treeMenu(const QPoint &pos)
    }
    class DiskInfo {
        string m_mediaType
    }
    DeviceListWidget --> DiskInfo : uses
Loading

File-Level Changes

Change Details Files
Disable bad sector detection for SSD devices
  • Add condition to detect when info.m_mediaType equals “SSD”
  • Call actionVerifyRepair->setDisabled(true) inside the SSD branch
  • Add inline comment to explain disabling for SSD
application/widgets/devicelistwidget.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @itsXuSt - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Copy Markdown
Contributor Author

itsXuSt commented Aug 7, 2025

/merge

@deepin-bot deepin-bot Bot merged commit 1b299ea into linuxdeepin:release/1071 Aug 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants