fix: Disable bad sector detection for SSD devices#165
Merged
Conversation
Changes: 1. Added a condition to disable the bad sector detection feature for SSD devices in the device list widget. Log: Improved user experience by preventing unnecessary checks on SSDs. Bug: https://pms.uniontech.com/bug-view-327485.html
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdded a check in DeviceListWidget::treeMenu to disable the bad sector detection action for SSDs by disabling the Verify/Repair menu item when the device media type is “SSD”. Class diagram for DeviceListWidget changesclassDiagram
class DeviceListWidget {
void treeMenu(const QPoint &pos)
}
class DiskInfo {
string m_mediaType
}
DeviceListWidget --> DiskInfo : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
max-lvs
approved these changes
Aug 7, 2025
Johnson-zs
approved these changes
Aug 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, Johnson-zs, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Log: Improved user experience by preventing unnecessary checks on SSDs.
Bug: https://pms.uniontech.com/bug-view-327485.html
Summary by Sourcery
Disable the bad sector detection option for SSD devices in the device list widget to prevent unnecessary checks and improve user experience.
Bug Fixes:
Enhancements: