feat: updat translation#148
Conversation
Reviewer's GuideThis PR refines the English translation TS file by updating its XML header, synchronizing all location line numbers, and adding numerous new translation entries (marked unfinished), and adds sample translation invocations in main.cpp for testing coverage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <source>Radius</source> | ||
| <translation>Radius</translation> | ||
| </message> | ||
| <message> | ||
| <location filename="../src/deepin-draw/main.cpp" line="95"/> | ||
| <source>The quick brown fox jumps over the lazy dog</source> |
There was a problem hiding this comment.
issue: Eliminate debug translation entries
These test messages should be removed or moved to a dedicated test file, as they are not part of the production UI.
| <location filename="../src/application.cpp" line="407"/> | ||
| <location filename="../src/application.cpp" line="396"/> | ||
| <source>OK</source> | ||
| <translation>OK</translation> |
There was a problem hiding this comment.
suggestion: Avoid manual updates to TS tags
Using Qt’s lupdate tool will keep tags accurate and prevent errors from manual edits.
Suggested implementation:
<!-- <location filename="../src/application.cpp" line="396"/> -->After making this change, you should run the lupdate tool on your project to automatically regenerate all <location> tags with the correct file paths and line numbers. This will ensure that the translation source file remains accurate and maintainable.
log: test translation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@JWWTSL: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
log: test translation
Summary by Sourcery
Refresh English translation files by adding missing entries, updating source locations, and inserting test translation strings.
Enhancements: