fix: Refactor file saving with memory validation

- Added memory checks before document processing
- Implemented TextFileSaver class for safer handling
- Optimized with chunked writes and progress events

Log: Improved file saving reliability with memory checks.

Author: rb-union

src/common/text_file_saver.cpp

@@ -8,9 +8,11 @@
  */
 
 #include "text_file_saver.h"
+#include "utils.h"
 #include "../encodes/detectcode.h"
 
 #include <QSaveFile>
+#include <QApplication>
 #include <QFileInfo>
 #include <QTextCodec>
 #include <QDebug>
@@ -122,6 +124,14 @@ bool TextFileSaver::saveToFile(QFileDevice &file)
             return false;
         }
 
+        auto characterCount = m_document->characterCount();
+        // Check memory for document content (QChar is 2 bytes)
+        qlonglong docMemoryNeeded = characterCount * 2;
+        if (!Utils::isMemorySufficientForOperation(Utils::OperationType::RawOperation, docMemoryNeeded, characterCount)) {
+            m_errorString = QObject::tr("Insufficient memory to load document content");
+            return false;
+        }
+
         const QString content = m_document->toPlainText();
         const ushort *data = content.utf16();
         const int length = content.length();
@@ -132,8 +142,16 @@ bool TextFileSaver::saveToFile(QFileDevice &file)
         for (int i = 0; i < length; i += chunkSize) {
             int currentChunkSize = qMin(chunkSize, length - i);
             QByteArray input(reinterpret_cast<const char *>(data + i), currentChunkSize * sizeof(ushort));
-            QByteArray outData;
 
+            // Check memory for encoding conversion (input + estimated output size)
+            qlonglong conversionMemoryNeeded = input.size() * 2;  // Estimate 2x for worst case
+            if (!Utils::isMemorySufficientForOperation(
+                    Utils::OperationType::RawOperation, conversionMemoryNeeded, characterCount)) {
+                m_errorString = QObject::tr("Insufficient memory for encoding conversion");
+                return false;
+            }
+
+            QByteArray outData;
             if (!convertEncoding(input, outData)) {
                 m_errorString = QObject::tr("Encoding conversion failed");
                 return false;
@@ -144,6 +162,8 @@ bool TextFileSaver::saveToFile(QFileDevice &file)
                 return false;
             }
 
+            QApplication::processEvents();
+
             qint64 written = file.write(outData);
             if (written != outData.size()) {
                 m_errorString = file.errorString();
@@ -164,15 +184,6 @@ bool TextFileSaver::saveToFile(QFileDevice &file)
     }
 }
 
-/**
- * @brief Gets the document content as plain text
- * @return The document content as QString
- */
-QString TextFileSaver::getDocumentContent() const
-{
-    return m_document->toPlainText();
-}
-
 /**
  * @brief Converts between character encodings
  * @param input The input byte array to convert

src/common/text_file_saver.h

@@ -25,7 +25,6 @@ class TextFileSaver
 
 private:
     bool saveToFile(QFileDevice &file);
-    QString getDocumentContent() const;
     bool convertEncoding(QByteArray &input, QByteArray &output) const;
 
 private:

src/common/utils.cpp

@@ -1191,38 +1191,55 @@ bool Utils::isMemorySufficientForOperation(OperationType operationType, qlonglon
     qlonglong totalMemoryBytes = memoryTotal * DATA_SIZE_1024;
 
     // Judge based on operation type
-    if (operationType == OperationType::CopyOperation) {
-        // Copy operation: Estimated memory consumption = data size * factor
-        qlonglong estimatedMemoryNeeded = operationDataSize * COPY_CONSUME_MEMORY_MULTIPLE;
-        if (estimatedMemoryNeeded > availableMemoryBytes) {
-            qWarning() << "Utils: Insufficient memory for copy operation. Needed(est):" << estimatedMemoryNeeded << "Available:" << availableMemoryBytes;
-            return false;
-        }
-    } else if (operationType == OperationType::PasteOperation) {
-        // Paste operation: Estimated memory consumption = paste data size * factor
-        qlonglong estimatedMemoryNeededForPaste = operationDataSize * PASTE_CONSUME_MEMORY_MULTIPLE;
-        // Estimated total document memory after paste
-        qlonglong estimatedTotalDocMemory = (currentDocumentSize + operationDataSize) * PASTE_CONSUME_MEMORY_MULTIPLE; // Estimate using paste factor
-
-        // Check if pasting the data itself would cause insufficient memory
-        if (estimatedMemoryNeededForPaste > availableMemoryBytes) {
-            qWarning() << "Utils: Insufficient memory for paste operation (paste data). Needed(est):" << estimatedMemoryNeededForPaste << "Available:" << availableMemoryBytes;
-            return false;
+    switch (operationType) {
+        case OperationType::RawOperation:
+            // Raw operation: Directly compare the data size with available memory
+            if (operationDataSize > availableMemoryBytes) {
+                qWarning() << "Utils: Insufficient memory for raw operation. Needed:" << operationDataSize << "Available:" << availableMemoryBytes;
+                return false;
+            }
+            break;
+            
+        case OperationType::CopyOperation: {
+            // Copy operation: Estimated memory consumption = data size * factor
+            qlonglong estimatedMemoryNeeded = operationDataSize * COPY_CONSUME_MEMORY_MULTIPLE;
+            if (estimatedMemoryNeeded > availableMemoryBytes) {
+                qWarning() << "Utils: Insufficient memory for copy operation. Needed(est):" << estimatedMemoryNeeded << "Available:" << availableMemoryBytes;
+                return false;
+            }
+            break;
         }
+            
+        case OperationType::PasteOperation: {
+            // Paste operation: Estimated memory consumption = paste data size * factor
+            qlonglong estimatedMemoryNeededForPaste = operationDataSize * PASTE_CONSUME_MEMORY_MULTIPLE;
+            // Estimated total document memory after paste
+            qlonglong estimatedTotalDocMemory = (currentDocumentSize + operationDataSize) * PASTE_CONSUME_MEMORY_MULTIPLE;
+
+            // Check if pasting the data itself would cause insufficient memory
+            if (estimatedMemoryNeededForPaste > availableMemoryBytes) {
+                qWarning() << "Utils: Insufficient memory for paste operation (paste data). Needed(est):" << estimatedMemoryNeededForPaste << "Available:" << availableMemoryBytes;
+                return false;
+            }
 
-        // Check if the estimated total document size after paste exceeds total system memory (very rough check)
-        if (estimatedTotalDocMemory > totalMemoryBytes) {
-            qWarning() << "Utils: Paste operation might exceed total system memory. Estimated total doc memory:" << estimatedTotalDocMemory << "Total system memory:" << totalMemoryBytes;
-            return false;
-        }
+            // Check if the estimated total document size after paste exceeds total system memory
+            if (estimatedTotalDocMemory > totalMemoryBytes) {
+                qWarning() << "Utils: Paste operation might exceed total system memory. Estimated total doc memory:" << estimatedTotalDocMemory << "Total system memory:" << totalMemoryBytes;
+                return false;
+            }
 
-        // Check specific threshold: Restrict paste size if document reaches 800MB
-        const qlonglong DOC_SIZE_LIMIT_800MB = 800LL * DATA_SIZE_1024 * DATA_SIZE_1024;
-        const qlonglong PASTE_SIZE_LIMIT_500KB = 500LL * DATA_SIZE_1024;
-        if (currentDocumentSize > DOC_SIZE_LIMIT_800MB && operationDataSize > PASTE_SIZE_LIMIT_500KB) {
-            qWarning() << "Utils: Paste operation restricted. Document size exceeds 800MB and paste data exceeds 500KB.";
-            return false;
+            // Check specific threshold: Restrict paste size if document reaches 800MB
+            const qlonglong DOC_SIZE_LIMIT_800MB = 800LL * DATA_SIZE_1024 * DATA_SIZE_1024;
+            const qlonglong PASTE_SIZE_LIMIT_500KB = 500LL * DATA_SIZE_1024;
+            if (currentDocumentSize > DOC_SIZE_LIMIT_800MB && operationDataSize > PASTE_SIZE_LIMIT_500KB) {
+                qWarning() << "Utils: Paste operation restricted. Document size exceeds 800MB and paste data exceeds 500KB.";
+                return false;
+            }
+            break;
         }
+
+        default:
+            break;
     }
 
     return true; // Memory is sufficient

src/common/utils.h

@@ -52,7 +52,8 @@ class Utils
      */
     enum OperationType {
         CopyOperation,
-        PasteOperation
+        PasteOperation,
+        RawOperation
     };
 
     /**