Skip to content

fix: improve MIME type detection and add man page support#349

Merged
max-lvs merged 1 commit into
linuxdeepin:release/eaglefrom
liyigang1:release/eagle
Apr 23, 2025
Merged

fix: improve MIME type detection and add man page support#349
max-lvs merged 1 commit into
linuxdeepin:release/eaglefrom
liyigang1:release/eagle

Conversation

@liyigang1
Copy link
Copy Markdown
Contributor

@liyigang1 liyigang1 commented Apr 23, 2025

Change MIME type detection to use content-based matching for more accurate file type recognition
Add application/x-troff-man MIME type to supported file types list

This improves file type detection accuracy by examining file contents
rather than relying solely on file extensions.

Log: improve MIME type detection and add man page support
Bug: https://pms.uniontech.com//bug-view-314393.html

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @liyigang1 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding the MIME type to a dedicated configuration file instead of hardcoding it.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 23, 2025

Reviewer's Guide by Sourcery

This pull request adds support for man page files by including the application/x-troff-man MIME type to the list of supported file types. This enables the application to open and edit man page files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added support for the application/x-troff-man MIME type.
  • Added application/x-troff-man to the list of supported MIME types.
src/common/utils.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@liyigang1 liyigang1 force-pushed the release/eagle branch 2 times, most recently from b652ab0 to cad712a Compare April 23, 2025 08:53
@liyigang1 liyigang1 changed the title fix: add support for man page file format fix: improve MIME type detection and add man page support Apr 23, 2025
- Change MIME type detection to use content-based matching for more accurate file type recognition
- Add application/x-troff-man MIME type to supported file types list

This improves file type detection accuracy by examining file contents
rather than relying solely on file extensions.

Log: improve MIME type detection and add man page support
Bug: https://pms.uniontech.com//bug-view-314393.html
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 代码修改使用了QMimeDatabase::MatchMode::MatchContent来获取文件类型,这可能会提高准确性,但需要确保这一改动不会对性能产生负面影响。

是否建议立即修改:

  • 否,这个改动看起来是有意为之,以提高文件类型的准确性。但是,需要进一步测试以确保性能不会受到影响,并且不会引入新的错误。如果测试结果表明性能没有问题,那么可以接受这个改动。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 32edf77 into linuxdeepin:release/eagle Apr 23, 2025
18 of 20 checks passed
pppanghu77 pushed a commit to pppanghu77/deepin-editor that referenced this pull request Dec 18, 2025
…n#349)

- Change MIME type detection to use content-based matching for more accurate file type recognition
- Add application/x-troff-man MIME type to supported file types list

This improves file type detection accuracy by examining file contents
rather than relying solely on file extensions.

Log: improve MIME type detection and add man page support
Bug: https://pms.uniontech.com//bug-view-314393.html
deepin-bot Bot pushed a commit that referenced this pull request Dec 18, 2025
- Change MIME type detection to use content-based matching for more accurate file type recognition
- Add application/x-troff-man MIME type to supported file types list

This improves file type detection accuracy by examining file contents
rather than relying solely on file extensions.

Log: improve MIME type detection and add man page support
Bug: https://pms.uniontech.com//bug-view-314393.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants