From 4669076f9a550fb70e5cc85c73eba919b63225e8 Mon Sep 17 00:00:00 2001 From: zhanghongyuan Date: Thu, 24 Jul 2025 10:13:17 +0800 Subject: [PATCH] fix: Remove the "Translate" option Remove the "Translate" option from the original right-click menu in the text editor Log: Remove the "Translate" option from the original right-click menu in the text editor Task: https://pms.uniontech.com/task-view-378241.html --- src/editor/dtextedit.cpp | 27 ++++++++++++----------- src/editor/dtextedit.h | 4 ++-- tests/src/editor/ut_textedit.cpp | 38 ++++++++++++++++---------------- 3 files changed, 35 insertions(+), 34 deletions(-) diff --git a/src/editor/dtextedit.cpp b/src/editor/dtextedit.cpp index 735b04fa9..2daa04e2e 100644 --- a/src/editor/dtextedit.cpp +++ b/src/editor/dtextedit.cpp @@ -300,7 +300,7 @@ void TextEdit::initRightClickedMenu() m_toggleCommentAction = new QAction(tr("Add Comment"), this); m_voiceReadingAction = new QAction(tr("Text to Speech"), this); m_dictationAction = new QAction(tr("Speech to Text"), this); - m_translateAction = new QAction(tr("Translate"), this); + // m_translateAction = new QAction(tr("Translate"), this); m_columnEditAction = new QAction(tr("Column Mode"), this); m_addBookMarkAction = new QAction(tr("Add bookmark"), this); m_cancelBookMarkAction = new QAction(tr("Remove Bookmark"), this); @@ -375,7 +375,7 @@ void TextEdit::initRightClickedMenu() connect(m_cancelComment, &QAction::triggered, this, &TextEdit::slotCancelComment); connect(m_voiceReadingAction, &QAction::triggered, this, &TextEdit::slotVoiceReadingAction); connect(m_dictationAction, &QAction::triggered, this, &TextEdit::slotdictationAction); - connect(m_translateAction, &QAction::triggered, this, &TextEdit::slot_translate); + // connect(m_translateAction, &QAction::triggered, this, &TextEdit::slot_translate); connect(m_columnEditAction, &QAction::triggered, this, &TextEdit::slotColumnEditAction); connect(m_addBookMarkAction, &QAction::triggered, this, &TextEdit::addOrDeleteBookMark); connect(m_cancelBookMarkAction, &QAction::triggered, this, &TextEdit::addOrDeleteBookMark); @@ -585,7 +585,7 @@ void TextEdit::popRightMenu(QPoint pos) } else { m_dictationAction->setEnabled(true); } - + /* m_translateAction->setEnabled(false); bool translateState = false; QDBusMessage translateReadingMsg = QDBusMessage::createMethodCall("com.iflytek.aiassistant", @@ -604,6 +604,7 @@ void TextEdit::popRightMenu(QPoint pos) if ((textCursor().hasSelection() && translateState) || m_hasColumnSelection) { m_translateAction->setEnabled(translateState); } + */ if (!this->document()->isEmpty()) { m_colorMarkMenu->clear(); @@ -3800,10 +3801,10 @@ void TextEdit::restoreMarkStatus() } -void TextEdit::slot_translate() -{ - QProcess::startDetached("dbus-send --print-reply --dest=com.iflytek.aiassistant /aiassistant/deepinmain com.iflytek.aiassistant.mainWindow.TextToTranslate"); -} +// void TextEdit::slot_translate() +// { +// QProcess::startDetached("dbus-send --print-reply --dest=com.iflytek.aiassistant /aiassistant/deepinmain com.iflytek.aiassistant.mainWindow.TextToTranslate"); +// } QString TextEdit::getWordAtCursor() { @@ -5663,9 +5664,9 @@ bool TextEdit::eventFilter(QObject *object, QEvent *event) QList touchPoints = touchEvent->touchPoints(); QMouseEvent *event2 = static_cast(event); DPlainTextEdit::mousePressEvent(event2); - if (touchPoints.count() == 3) { - slot_translate(); - } + // if (touchPoints.count() == 3) { + // slot_translate(); + // } break; } default: break; @@ -6387,9 +6388,9 @@ void TextEdit::onSelectionArea() void TextEdit::fingerZoom(QString name, QString direction, int fingers) { - if (name == "tap" && fingers == 3) { - slot_translate(); - } + // if (name == "tap" && fingers == 3) { + // slot_translate(); + // } // 当前窗口被激活,且有焦点 if (hasFocus()) { if (name == "pinch" && fingers == 2) { diff --git a/src/editor/dtextedit.h b/src/editor/dtextedit.h index 59a590fb6..a3bf28318 100644 --- a/src/editor/dtextedit.h +++ b/src/editor/dtextedit.h @@ -484,7 +484,7 @@ public slots: void handleScrollFinish(); void setSyntaxDefinition(KSyntaxHighlighting::Definition def); - void slot_translate(); + // void slot_translate(); //书签右键菜单功能 void setHighLineCurrentLine(bool ok); @@ -677,7 +677,7 @@ private slots: QAction *m_toggleCommentAction; QAction *m_voiceReadingAction; QAction *m_dictationAction; - QAction *m_translateAction; + // QAction *m_translateAction; QAction *m_columnEditAction; QAction *m_addBookMarkAction; diff --git a/tests/src/editor/ut_textedit.cpp b/tests/src/editor/ut_textedit.cpp index fc1f3bd2d..e0181f875 100644 --- a/tests/src/editor/ut_textedit.cpp +++ b/tests/src/editor/ut_textedit.cpp @@ -4835,25 +4835,25 @@ TEST_F(test_textedit, handleScrollFinish) } // void slot_translate(); -TEST_F(test_textedit, slot_translate) -{ - QList listSelection; - QTextEdit::ExtraSelection selectio; - QScrollBar *p = new QScrollBar(); - TextEdit *startManager = new TextEdit(); - startManager->setVerticalScrollBar(p); - EditWrapper *ee = new EditWrapper(); - Settings *s = new Settings(); - startManager->setSettings(s); - startManager->setWrapper(ee); - startManager->slot_translate(); - - EXPECT_NE(ee->m_pTextEdit , nullptr); - s->deleteLater(); - ee->deleteLater(); - startManager->deleteLater(); - p->deleteLater(); -} +// TEST_F(test_textedit, slot_translate) +// { +// QList listSelection; +// QTextEdit::ExtraSelection selectio; +// QScrollBar *p = new QScrollBar(); +// TextEdit *startManager = new TextEdit(); +// startManager->setVerticalScrollBar(p); +// EditWrapper *ee = new EditWrapper(); +// Settings *s = new Settings(); +// startManager->setSettings(s); +// startManager->setWrapper(ee); +// startManager->slot_translate(); + +// EXPECT_NE(ee->m_pTextEdit , nullptr); +// s->deleteLater(); +// ee->deleteLater(); +// startManager->deleteLater(); +// p->deleteLater(); +// } #if 0 //gerrit上段错误，暂且屏蔽 // void upcaseWord();