Skip to content

fix: remove deepin prefix from Chinese translations in desktop file#875

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n
Jul 16, 2026
Merged

fix: remove deepin prefix from Chinese translations in desktop file#875
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n

Conversation

@add-uos

@add-uos add-uos commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。

Summary by Sourcery

Bug Fixes:

  • Remove redundant "深度"/"deepin"/"Deepin" prefixes from zh_CN, zh_HK, and zh_TW Name/Comment translations in the deepin-screen-recorder desktop file.

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment
fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。
@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates Chinese translations in the deepin-screen-recorder desktop file by removing the "深度"/"deepin"/"Deepin" brand prefix from Name and Comment fields for zh_CN, zh_HK, and zh_TW locales.

File-Level Changes

Change Details Files
Normalize Chinese desktop entry translations by removing the Deepin brand prefix from Name/Comment fields for specific locales.
  • Update zh_CN Name and Comment translations to drop any leading "深度"/"deepin"/"Deepin" text while keeping the functional app description intact.
  • Apply the same prefix removal for zh_HK Name and Comment translations.
  • Apply the same prefix removal for zh_TW Name and Comment translations.
  • Ensure the desktop entry keys and non-Chinese translations remain unchanged.
deepin-screen-recorder.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码实现了繁体中文应用名称的本地化修正,无任何安全与逻辑问题
逻辑正确且符合本地化规范,无扣分项

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

具体分析内容:在 deepin-screen-recorder.desktop 文件的第128和129行,仅对 Name[zh_HK] 和 Name[zh_TW] 的值进行字符串裁剪,去除了多余的 "Deepin " 前缀,符合 Desktop Entry Specification 规范,无语法错误。
建议:无需改进

  • 2.代码质量(良好)✓

具体分析内容:修改使得繁体中文的命名风格与简体中文(zh_CN=截图录屏)的简洁风格保持一致,提升了多语言本地化文案的统一性和用户体验。
建议:无需改进

  • 3.代码性能(无性能问题)✓

具体分析内容:本次变更为纯静态配置文件中的字符串修改,不涉及任何程序运行时的计算、内存分配或系统调用,对性能无任何影响。
建议:无需改进

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
总体风险描述:纯文本翻译修正,不包含任何可执行逻辑、外部命令调用或敏感信息,无攻击面。

  • 建议:无需改进

■ 【改进建议代码示例】

--- a/deepin-screen-recorder.desktop
+++ b/deepin-screen-recorder.desktop
@@ -126,8 +126,8 @@ Name[ug]=Deepin ئېكراننى رەسىم تۇتۇش، سىنغا ئېلىش
 Name[uk]=Записувач з екрана Deepin
 Name[lo]=Deepin ບັນທຶກໜ້າຈໍ
 Name[zh_CN]=截图录屏
-Name[zh_HK]=Deepin 螢幕錄影
-Name[zh_TW]=Deepin 螢幕錄影
+Name[zh_HK]=螢幕錄影
+Name[zh_TW]=螢幕錄影
 
 [Desktop Action FullScreenShot]
 Exec=dbus-send --print-reply --dest=com.deepin.Screenshot /com/deepin/Screenshot com.deepin.Screenshot.FullscreenScreenshot

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 7352b6d into linuxdeepin:master Jul 16, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants