Skip to content

fix: notification show lag#660

Closed
18202781743 wants to merge 1 commit into
linuxdeepin:develop/snipefrom
18202781743:master
Closed

fix: notification show lag#660
18202781743 wants to merge 1 commit into
linuxdeepin:develop/snipefrom
18202781743:master

Conversation

@18202781743

Copy link
Copy Markdown
Contributor

It's obvious when the amount of data is large.
QTextInput will block to fetch clipboard when it's not readOnly, it will block GUI thread,
We send notification after saved to clipboard.

pms: BUG-297317

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, rb-union

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It's obvious when the amount of data is large.
QTextInput will block to fetch clipboard when it's not readOnly,
it will block GUI thread,
We send notification after saved to clipboard.

pms: BUG-297317
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • save2Clipboard(newSavePath); 函数调用被移动到了 exitRecord 函数的末尾,这可能会影响通知消息的显示顺序,因为通知消息的显示是在 save2Clipboard 调用之前的。

是否建议立即修改:

  • 是,建议将 save2Clipboard(newSavePath); 函数调用移回原来的位置,以确保通知消息和剪切板保存操作的顺序正确。

@deepin-bot

deepin-bot Bot commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.5.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #663

@deepin-bot

deepin-bot Bot commented May 8, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.5.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #665

@deepin-bot

deepin-bot Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.5.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #667

@18202781743

Copy link
Copy Markdown
Contributor Author

在dde-shell播放动画的地方修改,
linuxdeepin/dde-shell#1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants