Skip to content

fix: Remove unused VAAPI libraries from project configuration#767

Merged
lzwind merged 2 commits into
linuxdeepin:develop/snipefrom
dengzhongyuan365-dev:treelandcommit1
Nov 27, 2025
Merged

fix: Remove unused VAAPI libraries from project configuration#767
lzwind merged 2 commits into
linuxdeepin:develop/snipefrom
dengzhongyuan365-dev:treelandcommit1

Conversation

@dengzhongyuan365-dev

Copy link
Copy Markdown
Member

fix: Remove unused VAAPI libraries from project configuration

  • Updated the project file to remove the VAAPI-related libraries from the LIBS variable, streamlining the build configuration.
  • This change helps to reduce unnecessary dependencies and improve project maintainability.

This update ensures that the project remains focused on relevant libraries, enhancing overall build efficiency.

- Updated the project file to remove the VAAPI-related libraries from the LIBS variable, streamlining the build configuration.
- This change helps to reduce unnecessary dependencies and improve project maintainability.

This update ensures that the project remains focused on relevant libraries, enhancing overall build efficiency.
- update version to 6.6.14

log: update version to 6.6.14
@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.6.14
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

我来对这个git diff进行审查:

  1. 语法逻辑:
  • changelog文件的格式正确,遵循了Debian的changelog格式规范
  • src.pro文件中的修改语法正确,只是简单地移除了一些库链接
  1. 代码质量:
  • changelog中的描述比较简洁,但可以更具体一些:
    • "support treeland record" 可以更详细说明treeland是什么以及具体支持了什么功能
    • "adjust ai button style" 可以说明具体的调整内容
  • 移除libva和libva-drm库的链接应该有相应的说明,因为这可能影响视频硬件加速功能
  1. 代码性能:
  • 移除libva相关库可能会影响视频录制的性能,因为VA-API主要用于硬件加速视频编码
  • 建议确认移除这些库的影响,并确保软件编码的性能满足需求
  1. 代码安全:
  • 这个修改本身没有直接的安全问题
  • 但是移除硬件加速支持可能会导致更高的CPU使用率,在长时间录制时可能会影响系统稳定性

改进建议:

  1. 在changelog中添加更详细的变更说明
  2. 在src.pro中添加注释说明移除libva相关库的原因
  3. 考虑添加配置选项,让用户可以选择是否启用硬件加速
  4. 建议进行性能测试,确保移除硬件加速后的性能影响在可接受范围内
  5. 如果移除硬件加速是临时性的,建议在changelog中说明这是一个临时措施

示例改进后的changelog:

deepin-screen-recorder (6.6.14) unstable; urgency=medium

  * feat: Add support for Wayland-based Treeland session recording
  * feat: Redesign AI assistant button with new visual style
  * change: Temporarily disable VA-API hardware acceleration due to compatibility issues

  -- dengzhongyuan <dengzhongyuan@uniontech.com>  Thu, 27 Nov 2025 14:09:23 +0800

示例改进后的src.pro注释:

# Temporarily disabled VA-API libraries due to compatibility issues
# TODO: Re-enable hardware acceleration when issues are resolved
LIBS += -lX11 -lXext -lXtst -lXfixes -lXcursor -ldl -lXinerama -ldrm -lgbm

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit e05eaaf into linuxdeepin:develop/snipe Nov 27, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants