fix: Enable mouse pass-through for main window in X11 recording mode#768
Merged
deepin-bot[bot] merged 1 commit intoNov 27, 2025
Merged
fix: Enable mouse pass-through for main window in X11 recording mode#768deepin-bot[bot] merged 1 commit into
deepin-bot[bot] merged 1 commit into
Conversation
- Added conditional logic to enable mouse pass-through for the main window when starting recording in X11 mode. - The pass-through is only activated when not in Wayland or Treeland modes, preventing interference with recording events. - Added Chinese comment explaining the X11-specific behavior for clarity. This update ensures proper event handling during screen recording across different display server protocols.
deepin pr auto review我来对这个代码变更进行审查:
改进建议:
总体来说,这是一个合理的代码修改,针对特定平台(X11)的特殊需求进行了适配,代码质量良好。 |
lzwind
approved these changes
Nov 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
83bccbe
into
linuxdeepin:develop/snipe
7 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Enable mouse pass-through for main window in X11 recording mode
This update ensures proper event handling during screen recording across different display server protocols.