fix: use treeland frame for text save and force text commit#776
Merged
deepin-bot[bot] merged 1 commit intoDec 11, 2025
Merged
Conversation
- in treeland text edit flow, render via paintImage (treeland frame) instead of fullscreen grab to avoid empty pixmap - when text input is open, force text edits to read-only, clear selection, then hide editor to commit content before saving - keeps non-treeland and non-text paths unchanged 修复:文本保存走 treeland 帧并强制提交文本 - treeland 文本流程改用 paintImage(treeland 帧叠加文字),避免全屏抓取为空图 - 输入框未关闭时,强制设为只读并清理选中,再隐藏编辑层,确保内容提交后保存 - 其他模式与非文本路径保持不变 bug: https://pms.uniontech.com/bug-view-342885.html
deepin pr auto review我来对这个diff进行代码审查:
总体来说,这个改动合理地处理了Treeland模式的特殊情况,代码质量良好,但还有进一步优化的空间。 |
lzwind
approved these changes
Dec 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/merge |
Contributor
|
This pr cannot be merged! (status: unstable) |
Member
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
1d50bde
into
linuxdeepin:develop/snipe
7 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复:文本保存走 treeland 帧并强制提交文本
bug: https://pms.uniontech.com/bug-view-342885.html